New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709911 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Notification taps are handled twice

Project Member Reported by edcourtney@chromium.org, Apr 10 2017

Issue description

Tapping (with a finger) on an ARC notification sends it a BODY_CLICKED event, but this is already handled. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39f8e8cde10ced24bf0dbcae7187995221f009fe

commit 39f8e8cde10ced24bf0dbcae7187995221f009fe
Author: edcourtney <edcourtney@chromium.org>
Date: Wed Apr 12 07:42:11 2017

[Notifications] Drop tap gestures for ArcCustomNotificationView.

The tap gesture is already handled on the Android side.

BUG= 709911 

Review-Url: https://codereview.chromium.org/2800383003
Cr-Commit-Position: refs/heads/master@{#463944}

[modify] https://crrev.com/39f8e8cde10ced24bf0dbcae7187995221f009fe/ui/arc/notification/arc_custom_notification_view.cc

Labels: Merge-Request-58 M-58
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 12 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-58 Merge-Approved-58
Labels: -Hotlist-Merge-Review
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 13 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5f4109bcab949cadd261b019c4c32577dd388ab

commit a5f4109bcab949cadd261b019c4c32577dd388ab
Author: Daichi Hirono <hirono@chromium.org>
Date: Thu Apr 13 02:21:31 2017

[Notifications] Drop tap gestures for ArcCustomNotificationView.

The tap gesture is already handled on the Android side.

BUG= 709911 

Review-Url: https://codereview.chromium.org/2800383003
Cr-Commit-Position: refs/heads/master@{#463944}
(cherry picked from commit 39f8e8cde10ced24bf0dbcae7187995221f009fe)

Review-Url: https://codereview.chromium.org/2810363002 .
Cr-Commit-Position: refs/branch-heads/3029@{#687}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/a5f4109bcab949cadd261b019c4c32577dd388ab/ui/arc/notification/arc_custom_notification_view.cc

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Comment 9 by cda...@chromium.org, May 24 2017

Components: UI>Shell>Notifications Platform>ARC

Sign in to add a comment