New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 709877 link

Starred by 1 user
Status: Archived
Owner:
yllin@chromium.org
Closed: Jun 2017
Cc:
█ wnhuang@chromium.org
yllin@chromium.org
█ stimim@chromium.org
█ shunhsingou@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

factory: Change ALS calibration to a standalone test

Project Member Reported by hungte@chromium.org, Apr 10 2017 
Need recommendations from camera factor experts.

Currently the ALS calibration is part of camera_fixture pytest. I wonder what's the reason, since ALS fixture is in fact not camera fixture?

Will it be easier to maintain if we isolate ALS calibration to its own test?

Comment 1 by yllin@chromium.org, May 3 2017

Owner: yllin@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, May 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/2451f0d86c74a5608d83d18301363357ff4e47f7

commit 2451f0d86c74a5608d83d18301363357ff4e47f7
Author: Yilun Lin <yllin@google.com>
Date: Tue May 23 17:24:03 2017

pytests: A new test 'als_fixture', isolated from camera_fixture.

Now, we do ALS (Ambient Light Sensor) calibration on an independent
fixture station, so we would like to move it to a standalone test.

BUG= chromium:709877 
TEST=manual test als_fixture on eve

Change-Id: Ic3c0d35fc7afe68ef31b121c921987a6250ad1f1
Reviewed-on: https://chromium-review.googlesource.com/496006
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Yilun Lin <yllin@chromium.org>

[modify] https://crrev.com/2451f0d86c74a5608d83d18301363357ff4e47f7/po/zh-CN.po
[add] https://crrev.com/2451f0d86c74a5608d83d18301363357ff4e47f7/py/test/pytests/als_fixture_static/als_fixture.css
[modify] https://crrev.com/2451f0d86c74a5608d83d18301363357ff4e47f7/py/test/pytests/camera_fixture_static/camera_fixture.js
[add] https://crrev.com/2451f0d86c74a5608d83d18301363357ff4e47f7/py/test/pytests/als_fixture.py
[add] https://crrev.com/2451f0d86c74a5608d83d18301363357ff4e47f7/py/test/pytests/als_fixture_static/als.params.sample
[add] https://crrev.com/2451f0d86c74a5608d83d18301363357ff4e47f7/py/test/pytests/als_fixture_static/als_fixture.js
[modify] https://crrev.com/2451f0d86c74a5608d83d18301363357ff4e47f7/py/test/pytests/camera_fixture.py
[modify] https://crrev.com/2451f0d86c74a5608d83d18301363357ff4e47f7/py/test/pytests/camera_fixture_static/camera.params.sample
[modify] https://crrev.com/2451f0d86c74a5608d83d18301363357ff4e47f7/py/test/pytests/camera_fixture_static/camera_fixture.html
[add] https://crrev.com/2451f0d86c74a5608d83d18301363357ff4e47f7/py/test/pytests/als_fixture_static/als_fixture.html

Comment 3 by yllin@chromium.org, Jun 26 2017

Status: Fixed (was: Untriaged)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment