New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709862 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Close button on notifications sometimes isn't visible on hover

Project Member Reported by edcourtney@chromium.org, Apr 10 2017

Issue description

Sometimes when first opening the notification center after a notification appears, the close button won't be visible.

This seems to happen only for notifications that appear as a toast first.

Repro steps:
1. Get a notification that shows as a toast
2. Open the notification center
3. Hover over the notification - close button doesn't show up
4. Close and re-open the notification center - close button now shows up on hover
 
Components: Platform>ARC
It happens only for Android notifications.

Yoshiki-san, should this be fixed in M-58?
It's good to have in M58 if possible.
Labels: M-58
Thank you for the info.

This happens when opening the message center while the toast is showing.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9871ced334b179dbe05c98c9e99bca5114a3bc5e

commit 9871ced334b179dbe05c98c9e99bca5114a3bc5e
Author: yhanada <yhanada@chromium.org>
Date: Wed Apr 12 07:48:09 2017

Create the control buttons on a notification when showing the buttons if needed.

BUG= 709862 

Review-Url: https://codereview.chromium.org/2809133002
Cr-Commit-Position: refs/heads/master@{#463947}

[modify] https://crrev.com/9871ced334b179dbe05c98c9e99bca5114a3bc5e/ui/arc/notification/arc_custom_notification_view.cc

Labels: Merge-Request-58
Project Member

Comment 7 by sheriffbot@chromium.org, Apr 12 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-58 Merge-Approved-58
Labels: -Hotlist-Merge-Review
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 14 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a0450855d5db05436c37e4fcd046150c7b7af3b

commit 9a0450855d5db05436c37e4fcd046150c7b7af3b
Author: yhanada <yhanada@chromium.org>
Date: Fri Apr 14 04:41:10 2017

Create the control buttons on a notification when showing the buttons if needed.

BUG= 709862 

Review-Url: https://codereview.chromium.org/2809133002
Cr-Commit-Position: refs/heads/master@{#463947}
(cherry picked from commit 9871ced334b179dbe05c98c9e99bca5114a3bc5e)

Review-Url: https://codereview.chromium.org/2816163002 .
Cr-Commit-Position: refs/branch-heads/3029@{#709}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/9a0450855d5db05436c37e4fcd046150c7b7af3b/ui/arc/notification/arc_custom_notification_view.cc

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
9334.69.0, 58.0.3029.112
Chrome OS 9334.69.0, 58.0.3029.112

Sign in to add a comment