New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709854 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug-Regression



Sign in to add a comment

{amd64,x86} incremental builders Archive step fail to zip factory_image.zip in

Project Member Reported by djkurtz@google.com, Apr 10 2017

Issue description

For example, amd64-generic-incremental has failed consistently, starting with [0]:

Apr 08 03:22	??	failure	#39233
Failed steps failed cbuildbot [amd64-generic-incremental] failed archive

[0] https://build.chromium.org/p/chromiumos/builders/amd64-generic-incremental

Archive step logs [1] show error messages like:

@@@STEP_FAILURE@@@
03:42:50: ERROR: <class 'chromite.lib.cros_build_lib.RunCommandError'>: return code: 18; command: zip -r /b/cbuild/external_master/buildbot_archive/amd64-generic-incremental/R59-9442.0.0-b39233/factory_image.zip . --include 'shopfloor/*' --include 'toolkit/*' --include 'setup/*' --include doc.zip
zip warning: Permission denied
...
  adding: setup/make_universal_factory_shim.sh
	zip warning: could not open for reading: setup/make_universal_factory_shim.sh
...
zip warning: Not all files were readable
  files/entries read:  17 (34M bytes)  skipped:  28 (210K bytes)

cmd=['zip', '-r', u'/b/cbuild/external_master/buildbot_archive/amd64-generic-incremental/R59-9442.0.0-b39233/factory_image.zip', '.', '--include', u'shopfloor/*', '--include', u'toolkit/*', '--include', u'setup/*', '--include', u'doc.zip'], cwd=/tmp/cbuildbot-tmpZwLlbC/cbuildbot_factoryQJmAr0
Traceback (most recent call last):
  File "/b/cbuild/external_master/chromite/lib/parallel.py", line 441, in _Run
    self._task(*self._task_args, **self._task_kwargs)
  File "/b/cbuild/external_master/chromite/cbuildbot/stages/artifact_stages.py", line 214, in BuildAndArchiveFactoryImages
    self._run.attrs.release_tag)
  File "/b/cbuild/external_master/chromite/cbuildbot/commands.py", line 2551, in BuildFactoryZip
    cros_build_lib.RunCommand(cmd, cwd=temp_dir, capture_output=True)
  File "/b/cbuild/external_master/chromite/lib/cros_build_lib.py", line 625, in RunCommand
    raise RunCommandError(msg, cmd_result)
RunCommandError: return code: 18; command: zip -r /b/cbuild/external_master/buildbot_archive/amd64-generic-incremental/R59-9442.0.0-b39233/factory_image.zip . --include 'shopfloor/*' --include 'toolkit/*' --include 'setup/*' --include doc.zip


[1] https://build.chromium.org/p/chromiumos/builders/amd64-generic-incremental/builds/39233/steps/Archive/logs/stdio

Failure starts between:
OK:      R59-9441.0.0
Not OK:  R59-9442.0.0

Not sure if this is due to factory specific changes or not, but GE shows the following changes in src/platform/factory:

34542d72	471229	35985483	Fri Apr 07 13:52:14 2017	stimim@google.com	station_entry: add options for clear caches
ca7b3f09	471126		Fri Apr 07 03:26:33 2017	kitching@google.com	instalog: fix 1204 typo in bigquery plugin
7a297449	471228	35985483	Fri Apr 07 13:51:29 2017	stimim@google.com	scan: merge barcode_scan_to_file into scan

 

Comment 1 by hungte@chromium.org, Apr 10 2017

Cc: hungte@chromium.org
Owner: ----
I don't think those changes matter. Since it's an incremental builder, it's probably some problem on that machine, or other infra changes. Removing myself from owner since I can't see anything to help here.

Comment 2 by hungte@chromium.org, Apr 10 2017

Cc: littlecvr@chromium.org
Meanwhile it's interesting that shopfloor/ was added without problem while setup/ was not. Those files were all created by src/platform/factory/devtools/mk/bundle.sh.

I can add some code to ensure the files should have been created with world readable permission.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/c180dac8363c584f4dd130d3f49d3a1969315352

commit c180dac8363c584f4dd130d3f49d3a1969315352
Author: Hung-Te Lin <hungte@chromium.org>
Date: Mon Apr 10 06:54:51 2017

devtools: Make sure installed bundle resources are world readable.

To make sure the files in bundle folder can be repacked without root
accounts, we do want to make sure all the folders and files are world
readable.

BUG= chromium:709854 
TEST=emerge-eve factory

Change-Id: I66f89ae84925b6ee0e34d69b26b68e718cbca85b
Reviewed-on: https://chromium-review.googlesource.com/472367
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Commit-Queue: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/c180dac8363c584f4dd130d3f49d3a1969315352/devtools/mk/bundle.sh

Comment 5 by hungte@chromium.org, Apr 10 2017

Status: Fixed (was: Available)
https://build.chromium.org/p/chromiumos/builders/amd64-generic-incremental/builds/39250

Turns green :)

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment