New issue
Advanced search Search tips

Issue 709847 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Add an autotest for thumbnail test in VDA unittest

Project Member Reported by wuchengli@chromium.org, Apr 10 2017

Issue description

VDA unittest is broken by graphics changes from time to time. wmatrix is often red. Actually most test cases in VDA unittests do not need rendering. We should separate the test cases to the ones that need rendering (like thumbnail) and the ones do not.

Two options to separate the autotest:
(1) video_VideoDecodeAccelerator and video_VideoDecodeAcceleratorNoRendering
(2) video_VideoDecodeAcceleratorRendering and video_VideoDecodeAccelerator
 
Labels: videoshortlist
Labels: -Pri-2 Pri-1
Summary: Add an autotest for thumbnail test in VDA unittest (was: Add an autotest for VDA unittest that do not need rendering)
Owen, Kuang-che and I discussed. The conclusion is to add an autotest for thumbnail test only because it requires rendering. We can disable rendering for the original video_VideoDecodeAccelerator by passing --rendering_fps=0.
Owner: kcwu@chromium.org
Status: Assigned (was: Available)
Kuang-che. Can you help with this?

Comment 5 by kcwu@chromium.org, May 23 2017

Status: Started (was: Assigned)
Cc: acourbot@chromium.org

Comment 7 by kcwu@chromium.org, Jun 1 2017

Cc: -acourbot@chromium.org
Owner: acourbot@chromium.org
Alex is kind to help. Thank you.
Steps:
(1) Add video_VDAThumbnail autotest.
Make a copy of video_VideoDecodeAccelerator and only run thumbnail test case.
(2) In video_VideoDecodeAccelerator, exclude thumbnail test case and add --rendering_fps=0 for the rest test cases.
(3) Fix video_VDAPerf.
Add a new VideoDecodeAccelerator::Client class that does cadence and doesn't actually render. This will require a refactor of video_decode_accelerator_unittest.cc. Another possibility is to modify GLRenderingVDAClient and add yet another parameter. This is not preferred because GLRenderingVDAClient is way too huge.

We can file a separate bug for (3) if we want.
After (1) and (2) are done, video_VideoDecodeAccelerator should be all green in wmatrix.
I filed  http://crbug.com/728504  for (3).
Labels: -videoshortlist
Status: Fixed (was: Started)
As the immediate issues with the test are fixed and the thumbnail test is working again, I'll close this.
We should have another issue created for further improvements for vdatest.
Labels: videoshortlist
Status: Assigned (was: Fixed)
This issue is still valid. This issue is not really about fixing thumbnail test. It's to separate the thumbnail test to a standalone autotest.

Most test cases in VDA unittest do not need rendering except thumbnail test. VDA unittest is broken by graphics or media CLs around every two weeks. When that happens, we lost the test results of all test cases. Separating them to two autotests can prevent it. I think this is very important.

Todos:
(1) Add video_VDAThumbnail autotest.
Make a copy of video_VideoDecodeAccelerator and only run thumbnail test case.
(2) In video_VideoDecodeAccelerator, exclude thumbnail test case and add --rendering_fps=0 for the rest test cases.
Also in favor of keeping it opened as it reminds me I need to address this sometime this month. :)
Hi. Any update for this?
Status: Started (was: Assigned)
I have been thinking a bit about this. I am not sure whether we need to split the VDA test into two, especially since these two test programs would end up being closely related and would share a lot of code.

How about instead refactoring VDA test such that display is not enabled for tests that don't need it, and thus only enabled for thumbnail? That way we would only have one binary. If we want to test thumbnail separately out of concern that it is more likely to fail, we can then call that binary twice with two different sets of unit tests to perform and end up with two different reports.

This would make this change easier to implement, and probably easier to maintain in the long-term too.

wuchengli@, is that sounds good to you I will rather go in that direction.
Status: WontFix (was: Started)
We decided to remove display functionality from vda unittest. For thumbnail test,  we'll replace it with a javascript test or make it not depend on ozone.

Sign in to add a comment