New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 709835 link

Starred by 1 user
Status: Fixed
Owner:
█ mgiuca@chromium.org
Long OOO (go/where-is-mgiuca)
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

git hyper-blame: --no-default-ignores argument is broken

Project Member Reported by mgiuca@chromium.org, Apr 10 2017 
depot-tools version: 7b2ca416e4
OS: Linux

What steps will reproduce the problem?
(1) git hyper-blame --no-default-ignores

What is the expected result?
It ignores .git-blame-ignore-revs.

What happens instead?
usage: git hyper-blame [-h] [-i REVISION] [--ignore-file FILE]
                       [--no-default-ignores NO_DEFAULT_IGNORES]
                       [REVISION] FILE
git hyper-blame: error: argument --no-default-ignores: expected one argument

--no-default-ignores is erroneously configured to accept an argument (it's supposed to be a simple switch).
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/17a530722bbcbcf4964fc8c27c6b0980986d682b

commit 17a530722bbcbcf4964fc8c27c6b0980986d682b
Author: Matt Giuca <mgiuca@chromium.org>
Date: Tue Apr 11 01:14:24 2017

git hyper-blame: Fixed --no-default-ignores option to not take argument.

BUG= 709835 

Change-Id: Ia203cf24adf752ef3acdf660b4fe0990503782b9
Reviewed-on: https://chromium-review.googlesource.com/472587
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>

[modify] https://crrev.com/17a530722bbcbcf4964fc8c27c6b0980986d682b/git_hyper_blame.py
[modify] https://crrev.com/17a530722bbcbcf4964fc8c27c6b0980986d682b/tests/git_hyper_blame_test.py

Comment 2 by mgiuca@chromium.org, Apr 11 2017

Status: Fixed (was: Started)
►

Sign in to add a comment