New issue
Advanced search Search tips

Issue 709818 link

Starred by 2 users
Status: Fixed
Owner:
dcheng@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 675877



Sign in to add a comment

Clean up unnecessary cpp checker things

Project Member Reported by dcheng@chromium.org, Apr 9 2017 
We probably don't need a lot of the rules in cpp.py. We should look into reducing/eliminating this completely.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a3b815809ac856a1c84db0a0c58565448d1f63e

commit 0a3b815809ac856a1c84db0a0c58565448d1f63e
Author: Daniel Cheng <dcheng@chromium.org>
Date: Sun Apr 09 21:44:58 2017

Remove style checker tests for '_' in names after the Blink Rename.

There's probably more to be removed, but this test is failing since
the logic for enforcing no underscores in names was already
removed.

BUG= 709818 
TBR=thakis@chromium.org

Change-Id: I961118114c99db5c0fb3f9c7a5b72ba831b8313b
Reviewed-on: https://chromium-review.googlesource.com/472230
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#463147}
[modify] https://crrev.com/0a3b815809ac856a1c84db0a0c58565448d1f63e/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py

Comment 2 by thakis@chromium.org, Jan 5 2018

Owner: dcheng@chromium.org
Status: Fixed (was: Available)
Let's call this done after https://chromium-review.googlesource.com/c/chromium/src/+/621956
►

Sign in to add a comment