New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709817 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 675877



Sign in to add a comment

Make WouldLoadReason a scoped enum

Project Member Reported by dcheng@chromium.org, Apr 9 2017

Issue description

Otherwise generic names like kInvalid leak into the Blink namespace.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4574c193f0c59d76a2c1314b0a3f1ea5a8a6279

commit c4574c193f0c59d76a2c1314b0a3f1ea5a8a6279
Author: Daniel Cheng <dcheng@chromium.org>
Date: Mon Apr 10 21:21:09 2017

Make WouldLoadReason a scoped enum.

Things like kInvalid and kCreated are too generic to end up in the
top-level Blink namespace. Changing this to be a scoped enum revealed
some difficulties with using/testing scoped enums in Blink which will be
addressed in followup CLs.

Bug:  709817 
Change-Id: Ied242566e204fb3ad6cbf7e703727eada698b57e
Reviewed-on: https://chromium-review.googlesource.com/473469
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#463397}
[modify] https://crrev.com/c4574c193f0c59d76a2c1314b0a3f1ea5a8a6279/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/c4574c193f0c59d76a2c1314b0a3f1ea5a8a6279/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/c4574c193f0c59d76a2c1314b0a3f1ea5a8a6279/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/c4574c193f0c59d76a2c1314b0a3f1ea5a8a6279/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/c4574c193f0c59d76a2c1314b0a3f1ea5a8a6279/third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp

Comment 2 by dcheng@chromium.org, Apr 11 2017

Status: Fixed (was: Assigned)

Comment 3 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 4 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment