New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709776 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit 16 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 687601



Sign in to add a comment

[Payments] Desktop: Make it impossible to pay with a card that has no billing address

Project Member Reported by ma...@chromium.org, Apr 9 2017

Issue description

(1) Should be impossible to pay if the card doesn't have a billing address.
(2) Should be possible to assign a billing address in the editor.
 

Comment 1 by ja...@blackfor.ge, Apr 10 2017

Modern payment processor such as Stripe and Braintree allows developer to integrate payment on their website that contains no billing address. Even apps like Uber does not require billing.

If security is your main concern, Chrome already validates a legitimate user by asking for CVV code.

This is not a bug per se.

Comment 3 by ma...@chromium.org, Apr 10 2017

Cc: rouslan@chromium.org zkoch@chromium.org
Thanks James. In the Basic Card Response spec [1], it is indeed optional. I'll inquire in which situation we (as the browser) want to require it for payment.

[1] https://www.w3.org/TR/payment-method-basic-card/
This was a decision by the Chrome team. We want to provide as much info to the merchant seller as possible to successfully complete the transaction. Note that this is already implemented on Android. This particular bug is for the desktop platforms to match the behavior. Go ahead with implementing this, please.

Comment 5 by zkoch@chromium.org, Apr 10 2017

I think making it impossible to return without is fine for now. I agree with what James is saying, but the reality is that this is merchant-dependent. Since we lack an affordance in the API to say what did you do need, it's safer from a UX POV to always return back the full set of details.

That said, not all card have billing addresses (e.g. China Union Pay), so this is fine for now, but it might change in the future.

Comment 6 by ma...@chromium.org, Apr 24 2017

Issue 713404 has been merged into this issue.

Comment 7 by ma...@chromium.org, Apr 24 2017

Cc: ma...@chromium.org
Owner: mad@chromium.org

Comment 8 by mad@chromium.org, Apr 24 2017

Status: Started (was: Assigned)

Comment 9 by mad@chromium.org, Apr 24 2017

Blocking: 687601
Project Member

Comment 10 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/faf8e1ebbc65063a01ada0f0c5ac8981076210cb

commit faf8e1ebbc65063a01ada0f0c5ac8981076210cb
Author: mad <mad@chromium.org>
Date: Wed May 10 11:30:02 2017

Add billing address as a mandatory field of Payments credit cards.

TBR=markusheintz@chromium.org
For trivial adaptation to API change in:
chrome/browser/browsing_data/autofill_counter_browsertest.cc

BUG= 709776 

Review-Url: https://codereview.chromium.org/2849523003
Cr-Commit-Position: refs/heads/master@{#470536}

[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/app/generated_resources.grd
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/browsing_data/autofill_counter_browsertest.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/contact_info_editor_view_controller.h
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/credit_card_editor_view_controller.h
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/credit_card_editor_view_controller_unittest.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/cvc_unmask_view_controller_browsertest.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/editor_view_controller.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/editor_view_controller.h
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/error_message_view_controller_browsertest.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/payment_method_view_controller.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/payment_method_view_controller_browsertest.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/payment_request_browsertest_base.h
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/payment_request_can_make_payment_metrics_browsertest.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/payment_request_dialog_view.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/payment_request_dialog_view.h
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/payment_sheet_view_controller_browsertest.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/profile_list_view_controller.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/autofill/core/browser/BUILD.gn
[add] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/autofill/core/browser/address_combobox_model.cc
[add] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/autofill/core/browser/address_combobox_model.h
[add] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/autofill/core/browser/address_combobox_model_unittest.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/autofill/core/browser/autofill_assistant_unittest.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/autofill/core/browser/autofill_external_delegate_unittest.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/autofill/core/browser/autofill_test_utils.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/autofill/core/browser/autofill_test_utils.h
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/autofill/core/browser/credit_card.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/autofill/core/browser/credit_card_unittest.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/autofill/core/browser/payments/full_card_request_unittest.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/autofill/core/browser/validation.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/autofill/core/browser/validation.h
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/autofill_strings.grdp
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/payments/content/payment_request_state.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/payments/core/autofill_payment_instrument.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/payments/core/autofill_payment_instrument_unittest.cc
[modify] https://crrev.com/faf8e1ebbc65063a01ada0f0c5ac8981076210cb/components/payments_strings.grdp

Comment 11 by mad@chromium.org, May 10 2017

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment