TemplateURL::GenerateKeyword should always convert result keyword to lowercase |
||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.110 YaBrowser/17.4.0.1854 (beta) Yowser/2.5 Safari/537.36 Steps to reproduce the problem: TemplateURL::GenerateKeyword returns keyword for search engine URL using GURL::host() method. TemplateURLService component that stores TemplateURLs assumes that keywords are always converted to lowercase. GURL::host() can return string with uppercase characters for some exotic URLs. For example for "http://embedded.<html>web" it will return "embedded.%3Ehtml%3Eweb". This could lead to problems when TemplateURLService tries to resolve conflicts between autogenerated keywords. What is the expected behavior? What went wrong? Not applicable Did this work before? N/A Chrome version: 57.0.2987.110 Channel: n/a OS Version: OS X 10.11.6 Flash Version: Shockwave Flash 25.0 r0
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81695d0da81e63990e210da79b7a65c7dd386140 commit 81695d0da81e63990e210da79b7a65c7dd386140 Author: a-v-y <a-v-y@yandex-team.ru> Date: Thu Apr 20 08:22:22 2017 Changed GenerateKeyword to always return keyword in lowercase TemplateURL::GenerateKeyword returns keyword for search engine URL using GURL::host() method. TemplateURLService component that stores TemplateURLs assumes that keywords are always converted to lowercase. GURL::host() can return string with uppercase characters for some exotic URLs. For example for "http://embedded.<html>web" it will return "embedded.%3Ehtml%3Eweb". This could lead to problems when TemplateURLService tries to resolve conflicts between autogenerated keywords. BUG= 709761 R=vasilii@chromium.org, pkasting@chromium.org Review-Url: https://codereview.chromium.org/2806593006 Cr-Commit-Position: refs/heads/master@{#465946} [modify] https://crrev.com/81695d0da81e63990e210da79b7a65c7dd386140/chrome/browser/search_engines/template_url_service_unittest.cc [modify] https://crrev.com/81695d0da81e63990e210da79b7a65c7dd386140/components/search_engines/template_url.cc [modify] https://crrev.com/81695d0da81e63990e210da79b7a65c7dd386140/components/search_engines/template_url_unittest.cc
,
Apr 21 2017
Issue fixed and can be closed.
,
Apr 24 2017
Do you not have editbugs permissions? Do you want them?
,
Apr 25 2017
I have no permissions. It would be convenient to have them. More permissions == more power :)
,
Apr 26 2017
,
Apr 26 2017
Update: Your account should now have EditBugs permissions.
,
Apr 27 2017
Thanks a lot. |
||
►
Sign in to add a comment |
||
Comment 1 by tapted@chromium.org
, Apr 11 2017Labels: -OS-Mac OS-All