New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709758 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Bad DCHECK in safe_browsing::PasswordProtectionService::RemoveContentSettingsOnURLsDeleted

Project Member Reported by csharrison@chromium.org, Apr 8 2017

Issue description

[20641:20641:0408/144739.027843:FATAL:password_protection_service.cc(58)] Check failed: url.SchemeIsHTTPOrHTTPS(). data:text/html,<script src="/text" type="python"></script>?
#0 0x7f4d0778edf7 base::debug::StackTrace::StackTrace()
#1 0x7f4d077b27bb logging::LogMessage::~LogMessage()
#2 0x55fa8e477d7d safe_browsing::(anonymous namespace)::GetHostNameWithHTTPScheme()
#3 0x55fa8e478d6c safe_browsing::PasswordProtectionService::RemoveContentSettingsOnURLsDeleted()
#4 0x55fa8e479209 _ZN4base8internal7InvokerINS0_9BindStateIMN13safe_browsing25PasswordProtectionServiceEFvbRKSt6vectorIN7history6URLRowESaIS7_EEEJNS_7WeakPtrIS4_EEbS9_EEEFvvEE7RunImplIRKSD_RKSt5tupleIJSF_bS9_EEJLm0ELm1ELm2EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#5 0x7f4d0778f8e1 _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv
#6 0x7f4d0778f713 base::debug::TaskAnnotator::RunTask()
#7 0x7f4d077bf2ad base::MessageLoop::RunTask()
#8 0x7f4d077bf558 base::MessageLoop::DeferOrRunPendingTask()
#9 0x7f4d077bfa06 base::MessageLoop::DoWork()
#10 0x7f4d077c1bba base::(anonymous namespace)::WorkSourceDispatch()
#11 0x7f4d007bee04 g_main_context_dispatch
#12 0x7f4d007bf048 <unknown>
#13 0x7f4d007bf0ec g_main_context_iteration
#14 0x7f4d077c1916 base::MessagePumpGlib::Run()
#15 0x7f4d077bf00e base::MessageLoop::RunHandler()
#16 0x7f4d077f198c base::RunLoop::Run()
#17 0x55fa8e8f1354 ChromeBrowserMainParts::MainMessageLoopRun()
#18 0x7f4d04ea9653 content::BrowserMainLoop::RunMainMessageLoopParts()
#19 0x7f4d04eac6f7 content::BrowserMainRunnerImpl::Run()
#20 0x7f4d04ea4ba8 content::BrowserMain()
#21 0x7f4d056af9b3 content::RunNamedProcessTypeMain()
#22 0x7f4d056b0636 content::ContentMainRunnerImpl::Run()
#23 0x7f4cfcdf0f5f service_manager::Main()
#24 0x7f4d056af252 content::ContentMain()
#25 0x55fa8e1dfef1 ChromeMain

Looks like this is caused because I have non http/s URLs in my history. This is causing crashes a bit after startup for me.
 
Cc: jialiul@chromium.org
Components: Services>Safebrowsing
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2ed4b4539b7a50d8be892e4437897b18c181c91

commit e2ed4b4539b7a50d8be892e4437897b18c181c91
Author: csharrison <csharrison@chromium.org>
Date: Mon Apr 10 00:33:51 2017

Ensure password protection service can receive non http/s URLs

This fixes a wrong DCHECK where code does not expect deleted history
entries to be non-http/s.

BUG= 709758 

Review-Url: https://codereview.chromium.org/2811483002
Cr-Commit-Position: refs/heads/master@{#463157}

[modify] https://crrev.com/e2ed4b4539b7a50d8be892e4437897b18c181c91/components/safe_browsing/password_protection/password_protection_service.cc
[modify] https://crrev.com/e2ed4b4539b7a50d8be892e4437897b18c181c91/components/safe_browsing/password_protection/password_protection_service_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment