New issue
Advanced search Search tips

Issue 709729 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

LauncherContextMenuTest.ArcLauncherContextMenuItemCheck failing on Linux Chrome OS builders

Project Member Reported by jamescook@chromium.org, Apr 8 2017

Issue description

Started here https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/24583

[ RUN      ] LauncherContextMenuTest.ArcLauncherContextMenuItemCheck
Xlib:  extension "RANDR" missing on display ":99".
Received signal 11 <unknown> 000000000000
#0 0x7f8d89f0898b base::debug::StackTrace::StackTrace()
#1 0x7f8d89f076cc base::debug::StackTrace::StackTrace()
#2 0x7f8d89f0849f base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x7f8d8d8f2330 <unknown>
#4 0x7f8d7261e956 <unknown>
#5 0x7f8d7261e9a0 <unknown>
#6 0x7f8d818bb5f5 __gnu_debug::_Safe_iterator_base::_Safe_iterator_base()
#7 0x7f8d8190e470 __gnu_debug::_Safe_iterator<>::_Safe_iterator()
#8 0x7f8d8190e17f std::__debug::vector<>::begin()
#9 0x7f8d81951ea4 base::ObserverListBase<>::RemoveObserver()
#10 0x7f8d8194b120 aura::Window::RemoveObserver()
#11 0x000004cd7b64 ScopedObserver<>::RemoveAll()
#12 0x000004cd71a9 ScopedObserver<>::~ScopedObserver()
#13 0x00000843790c AppWindowLauncherItemController::~AppWindowLauncherItemController()
#14 0x0000082b4bba ArcAppWindowLauncherItemController::~ArcAppWindowLauncherItemController()
#15 0x0000082b4bf9 ArcAppWindowLauncherItemController::~ArcAppWindowLauncherItemController()
#16 0x7f8d7d82c56f std::default_delete<>::operator()()
#17 0x7f8d7d8dcdc3 std::unique_ptr<>::~unique_ptr()
#18 0x7f8d7d90b179 std::pair<>::~pair()
#19 0x7f8d7d90b159 std::_Rb_tree_node<>::~_Rb_tree_node()
#20 0x7f8d7d90b139 __gnu_cxx::new_allocator<>::destroy<>()
#21 0x7f8d7d90b10c std::_Rb_tree<>::_M_destroy_node()
#22 0x7f8d7d90b0c8 std::_Rb_tree<>::_M_erase()
#23 0x7f8d7d90b0ab std::_Rb_tree<>::_M_erase()
#24 0x7f8d7d90b0ab std::_Rb_tree<>::_M_erase()
#25 0x7f8d7d90b3d5 std::_Rb_tree<>::clear()
#26 0x7f8d7d90b1f5 std::__cxx1998::map<>::clear()
#27 0x7f8d7d908ac2 std::__debug::map<>::clear()
#28 0x7f8d7d90726c ash::ShelfModel::DestroyItemDelegates()
#29 0x7f8d7db9eb5e ash::Shell::~Shell()
#30 0x7f8d7db9fbc9 ash::Shell::~Shell()
#31 0x7f8d7db9b29d ash::Shell::DeleteInstance()
#32 0x000009340fcf ash::test::AshTestHelper::TearDown()
#33 0x00000933ef36 ash::test::AshTestBase::TearDown()
#34 0x000001c02263 LauncherContextMenuTest::TearDown()
#35 0x000001a7f55e _ZN7testing8internal12InvokeHelperIN16sync_file_system18RemoteServiceStateESt5tupleIJEEE12InvokeMethodINS2_25MockRemoteFileSyncServiceEMS8_KFS3_vEEES3_PT_T0_RKS5_
#36 0x0000049b55c2 testing::internal::HandleExceptionsInMethodIfSupported<>()
#37 0x0000049aa80b testing::Test::Run()
#38 0x0000049aaefd testing::TestInfo::Run()
#39 0x0000049ab49f testing::TestCase::Run()
#40 0x0000049b080c testing::internal::UnitTestImpl::RunAllTests()
#41 0x000001ee586e _ZN7testing8internal12InvokeHelperIbSt5tupleIJEEE12InvokeMethodI25MockServiceProcessControlMS6_FbvEEEbPT_T0_RKS3_
#42 0x0000049b6c02 testing::internal::HandleExceptionsInMethodIfSupported<>()
#43 0x0000049b04af testing::UnitTest::Run()
#44 0x000004768d41 RUN_ALL_TESTS()
#45 0x000004767c72 base::TestSuite::Run()
#46 0x0000048beced content::UnitTestTestSuite::Run()
#47 0x00000091b425 _ZN4base8internal13FunctorTraitsIMNS_7RunLoopEFvvEvE6InvokeIPS2_JEEEvS4_OT_DpOT0_
#48 0x00000091b341 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMNS_7RunLoopEFvvEJPS4_EEEvOT_DpOT0_
#49 0x000004753a87 _ZN4base8internal7InvokerINS0_9BindStateIMN7content17UnitTestTestSuiteEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#50 0x0000047539cc _ZN4base8internal7InvokerINS0_9BindStateIMN7content17UnitTestTestSuiteEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE
#51 0x000000963bbd _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv
#52 0x00000476bc8e base::(anonymous namespace)::LaunchUnitTestsInternal()
#53 0x00000476bb24 base::LaunchUnitTests()
#54 0x0000047537cc main
#55 0x7f8d71fb3f45 __libc_start_main
#56 0x00000090a0c4 <unknown>
  r8: 00007f8d728731f0  r9: 00007ffe5f1dd240 r10: fffffffffffffeb8 r11: 00007f8d7211bcf0
 r12: 00007ffe5f1dd640 r13: 0000000000000000 r14: 0000000000000000 r15: 0000000000000000
  di: 000029821c038430  si: 00007ffe5f1dd640  bp: 00007f8d728731f0  bx: 000029821c038430
  dx: 3636363636363636  ax: 000029821c038430  cx: 3d230dc165f4d188  sp: 00007ffe5f1dd258
  ip: 00007f8d7261e956 efl: 0000000000010206 cgf: 0000000000000033 erf: 0000000000000000
 trp: 000000000000000d msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
Calling _exit(1). Core file will not be generated.
[4643/8662] LauncherContextMenuTest.ArcLauncherContextMenuItemCheck (CRASHED)

I'm going to speculatively revert your recent CL.

 

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b88cc04e9b44a1738e3628835338077f49667675

commit b88cc04e9b44a1738e3628835338077f49667675
Author: msw <msw@chromium.org>
Date: Mon Apr 10 19:34:58 2017

mash: Fix controller ownership in LauncherContextMenuTest.

Similar to https://codereview.chromium.org/2804913002/
Tests should create, but not own the ChromeLauncherControllerImpl.
Instead, install the CLC as Shell's ShelfDelegate.

Also cleanup: expose command enum, remove friend tests.

Fixes the test from https://codereview.chromium.org/2798173002

BUG= 557406 , 709729 
TEST=Automated tests still pass; more closely match production.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2812693002
Cr-Commit-Position: refs/heads/master@{#463363}

[modify] https://crrev.com/b88cc04e9b44a1738e3628835338077f49667675/chrome/browser/ui/ash/launcher/launcher_context_menu.h
[modify] https://crrev.com/b88cc04e9b44a1738e3628835338077f49667675/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc

Comment 3 by msw@chromium.org, Apr 10 2017

Status: Fixed (was: Assigned)
The tests still pass after my CL re-landed with the above fix:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/24669
Status: Verified (was: Fixed)

Sign in to add a comment