Make DelegatedFrameEvictor talk directly to the display compositor |
|||||||
Issue descriptionCurrently DelegatedFrameHost is responsible for interacting with DelegatedFrameEvictor. I think ideally we should call the appropriate methods in DelegatedFrameEvictor upon receiving in frame in CompositorFrameSinkSupport without involving DelegatedFrameHost.
,
Apr 18 2017
This is probably not possible until CompositorFramesinkSupport is moved to viz. It currently lives in cc and we don't want cc to depend on viz, so we either need a virtual interface in cc or just move CompositorFrameSinkSupport to viz. I prefer the latter.
,
Apr 19 2017
,
Apr 20 2017
Please explain further how this would work.
,
Apr 20 2017
- void SwappedFrame(bool visible); At the end of SubmitCompositorFrame we call SwappedFrame. - void DiscardedFrame(); We call this in EvictFrame. - void SetVisible(bool visible); The display compositor should be able to tell if a surface is visible or not and call this method when its visibility changes. - void LockFrame(); - void UnlockFrame(); These two don't even seem to be used outside of tests.
,
Apr 25 2017
There are many cc unit cases depends on CompositorFrameSinkSupport, such as: Compositor_frame_sink_support_unittest.cc Direct_compositor_frame_sink_unittest.cc/By DirectCompositorFrameSink Surfaces_pixeltest.cc Surface_aggregator_perftest.cc Surface_aggregator_unittest.cc Surface_manager_ref_unittest.cc Surface_unittest.cc Test_compositor_frame_sink.cc Does it OK to move these unit test into viz too?
,
May 3 2017
,
May 8 2017
How about move the whole cc into components?
,
May 23 2017
,
Jun 13 2017
,
Jun 14 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 29 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by samans@chromium.org
, Apr 8 2017