New issue
Advanced search Search tips

Issue 709712 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocked on:
issue 710629



Sign in to add a comment

Add qemu/virtio VMTests to the CQ

Project Member Reported by norvez@chromium.org, Apr 8 2017

Issue description


VMTests currently run qemu with '-vga cirrus' in all cases. We now have support for '-vga virtio' but we don't test it and some regressions have recently made it past the CQ and the canaries.

We want to use virtio because cirrus limits us to 800x600. 800x600 is fine for automated tests, but not for humans actually using VMs. virtio doesn't put any (reasonable...) limitation on the resolution.
However, it does require support in the guest and that requires the guest to run kernel >= 4.4. This means VMTests for cyan, samus, ... must still run with '-vga cirrus' passed to qemu. Boards that use a 4.4 kernel (e.g. amd64-generic-cheets, betty, newbie) can and should run VMTests with 'qemu -vga virtio'.

TODO:
- add betty-paladin, no HWTests, only VMTests
- add ability to configure the options passed to qemu in VMTests. cirrus should still be the default but some builders should run them with virtio, in particular betty-paladin
 

Comment 1 by norvez@chromium.org, Apr 15 2017

Blockedon: 710629

Comment 2 by norvez@chromium.org, Jul 14 2017

Owner: norvez@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/83ee731349654af87677f72816e60dfd4526a358

commit 83ee731349654af87677f72816e60dfd4526a358
Author: Nicolas Norvez <norvez@chromium.org>
Date: Sat Jul 15 06:22:08 2017

cros_vm_lib: use virtio-gpu if supported

VM images for most boards only support cirrus, in particular when the
kernel is 3.18 or older.
Some boards, particularly the ones dedicated to VM targets, do support
virtio-gpu and are expected to use it to avoid being limited to 800x600
resolution.

betty, newbie and novato support virtio-gpu and their use case requires
it, so make them use virtio-gpu to catch regressions.

amd64-generic is not specifically a VM target but use virtio-gpu anyway
to provide a simple test case for external contributors.

BUG= chromium:709712 
BUG= chromium:741886 
TEST=./bin/cros_start_vm --board=novato starts qemu with '-vga virtio'
TEST=./bin/cros_start_vm --board=cyan starts qemu with '-vga cirrus'

Change-Id: I2f67347fde71c3cbfb25f5820d7df72daa936a4a
Reviewed-on: https://chromium-review.googlesource.com/572042
Commit-Ready: Nicolas Norvez <norvez@chromium.org>
Tested-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/83ee731349654af87677f72816e60dfd4526a358/lib/cros_vm_lib.sh

Comment 4 by norvez@chromium.org, Jul 15 2017

Status: Fixed (was: Assigned)

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment