Web payments UI overlaps Chrome Home omnibox. |
|||||||
Issue descriptionWhen Web Payments initially shipped, we were concerned that the payment UI was implementing its own half-baked version of omnibox URL formatting. This was mitigated by the fact that the omnibox was still visible in the background. The payment popup UI now uses scheme coloring from the omnibox, although it doesn't highlight the domain, and I don't know how it handles IDN domains and eliding. emilyschechter@: Do you think this is sufficiently mitigated if we get the payments team to copy all omnibox origin treatment (... and hopefully keep it in sync)? Or should we reconsider where to put the UI?
,
Apr 8 2017
Ah, interesting. This never clicked with me.
,
Apr 10 2017
> We show only the origin, so scheme + domain (most of the time). Should the domain be darker? Yes, it should match the omnibox. Note that we are researching new changes to the omnibox, so that might change again. Is it possible for you to share code with the Android omnibox, so that this code is automatically kept in sync?
,
Apr 10 2017
> Is it possible for you to share code with the Android omnibox, so that this code is automatically kept in sync? Yep, that would be wonderful. We'd need to do some refactoring.
,
Apr 10 2017
-me, +ted for omnibox code.
,
Apr 10 2017
Sorry, but I'm not clear on what code you're talking about. If this is just about coloring, you should use OmniboxUrlEmphasizer#emphasizeUrl
,
Apr 11 2017
,
Apr 11 2017
Looks legit to me. Nothing will ever look good with such a long domain name, IMO, so this seems like a good approach.
,
Apr 11 2017
Where do the green dots come from? The omnibox just truncates the URL. Ellipses are fine, but if the emphasizer is making them green we should fix that. Otherwise looks good to me. :-)
,
Apr 11 2017
Also, would you mind posting screenshots of the following to sanity check? https://long-extended-subdomain-name-containing-many-letters-and-dashes.badssl.com/input/web-payment/ https://long-extended-subdomain-name-containing-many-letters-and-dashes.badssl.com/input/web-payment/
,
Apr 11 2017
,
Apr 12 2017
We have a bug filed for removing the green color from the ellipsis. We can remove the ellipsis altogether to match the omnibox, if you think that's better. Darkening the hostname through OmniboxUrlEmphasizer#emphasizeUrl() is a good first step, though.
,
Apr 12 2017
> We have a bug filed for removing the green color from the ellipsis. Could you CC me? > We can remove the ellipsis altogether to match the omnibox I'm a bit concerned if you need to do this manually, since that could get out of sync again. Is it possible to display the origin in a frameless box, aligned like the omnibox?
,
Apr 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6b447c44b838ffccc0c2443991e7a8dfb30effa commit c6b447c44b838ffccc0c2443991e7a8dfb30effa Author: rouslan <rouslan@chromium.org> Date: Fri Apr 14 20:13:56 2017 Use common URL emphasizer for web payments. BUG=709666 Review-Url: https://codereview.chromium.org/2815623004 Cr-Commit-Position: refs/heads/master@{#464783} [modify] https://crrev.com/c6b447c44b838ffccc0c2443991e7a8dfb30effa/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/c6b447c44b838ffccc0c2443991e7a8dfb30effa/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestHeader.java [modify] https://crrev.com/c6b447c44b838ffccc0c2443991e7a8dfb30effa/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java [modify] https://crrev.com/c6b447c44b838ffccc0c2443991e7a8dfb30effa/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUiErrorView.java
,
Jun 19 2017
Assigning to myself to make sure this task is not lost.
,
Jun 27 2017
,
Nov 21 2017
,
Mar 10 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rouslan@chromium.org
, Apr 8 2017Components: -Blink>Payments UI>Browser>Autofill>Payments