Implement ConvolverNode.buffer setter correctly |
||||
Issue descriptionAs given in https://webaudio.github.io/web-audio-api/#widl-ConvolverNode-buffer, the buffer attribute of a ConvolverNode can only bet set to a non-null once. This is how AudioBufferSourceNode.buffer is handled. Make it so.
,
May 29 2018
Need to implement this. This is similar to AudioBufferSourceNode, where we've already done this.
,
May 30 2018
i will take this issue.
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1fa6d40966b5eb966feeed6fbe18675e819ff6d commit e1fa6d40966b5eb966feeed6fbe18675e819ff6d Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Wed Jun 27 14:43:45 2018 [WebAudio] throw an error when buffer has been already set. should throw an InvalidStateError when buffer has been already set in ConvolverNode Bug: 709656 Change-Id: Ia0826f9ffa2e180da1311f4cded8ff7fe5461147 Reviewed-on: https://chromium-review.googlesource.com/1077713 Reviewed-by: Raymond Toy <rtoy@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#570767} [add] https://crrev.com/e1fa6d40966b5eb966feeed6fbe18675e819ff6d/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-convolvernode-interface/convolver-setBuffer-already-has-value.html [modify] https://crrev.com/e1fa6d40966b5eb966feeed6fbe18675e819ff6d/third_party/blink/renderer/modules/webaudio/convolver_node.cc [modify] https://crrev.com/e1fa6d40966b5eb966feeed6fbe18675e819ff6d/third_party/blink/renderer/modules/webaudio/convolver_node.h
,
Jun 29 2018
This works as expected:
c = new AudioContext();
n = new ConvolverNode(c);
n.buffer = null; // no error
n.buffer = new AudioBuffer({length: 100, sampleRate: c.sampleRate}); // Ok
n.buffer = new AudioBuffer({length: 100, sampleRate: c.sampleRate}); // Error
n.buffer = null; // Ok
n.buffer = null; // Ok
n.buffer = new AudioBuffer({length: 100, sampleRate: c.sampleRate}); // Error
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sheriffbot@chromium.org
, Apr 11 2018Status: Untriaged (was: Available)