[MD settings] vertically align elements |
|||||||||||
Issue descriptionIn chrome://settings/content (and elsewhere) Notice how the indented items on the page no longer vertically aligns with the title text. "when we made the padding around the subpage arrow 20 and 20 it threw off the alignment of the the title header and the content below it so notice that Cookies, Location, etc don't line up with Site Settings, which they should" -- Alan Currently, the title line is considered correct, so the content should be adjusted to align with the title. This is much easier to understand with pictures:
,
Apr 10 2017
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ee0be28f0383dc0c4e5a6062bf7dd87df956cbd commit 8ee0be28f0383dc0c4e5a6062bf7dd87df956cbd Author: dschuyler <dschuyler@chromium.org> Date: Tue Apr 11 18:36:25 2017 [MD settings] vertical align left edge of icons and text This CL moves spacing around so that icons and text vertically align on the left edge. The old indent was 56px and the new indent is 60px. BUG= 709654 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2813803002 Cr-Commit-Position: refs/heads/master@{#463696} [modify] https://crrev.com/8ee0be28f0383dc0c4e5a6062bf7dd87df956cbd/chrome/browser/resources/settings/languages_page/edit_dictionary_page.html [modify] https://crrev.com/8ee0be28f0383dc0c4e5a6062bf7dd87df956cbd/chrome/browser/resources/settings/people_page/users_page.html [modify] https://crrev.com/8ee0be28f0383dc0c4e5a6062bf7dd87df956cbd/chrome/browser/resources/settings/settings_page/settings_subpage.html [modify] https://crrev.com/8ee0be28f0383dc0c4e5a6062bf7dd87df956cbd/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/8ee0be28f0383dc0c4e5a6062bf7dd87df956cbd/chrome/browser/resources/settings/settings_vars_css.html
,
Apr 11 2017
The above CL fixes several areas of the UI. See screen shots here.
,
Apr 11 2017
I think there may still be a chromeos only issue in the people section. I need to look into that further. We can mark this fixed and move the chromeos question to a new bug or keep this one open. For the moment, I'm leaving this one open.
,
Apr 11 2017
,
Apr 12 2017
I'm going to look into to chromeos question further, but I'm marking this fixed since the actual reported issues are fixed.
,
Apr 12 2017
(chromeos follow-up at Issue 710704 )
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc24ac56413d35a83928c20bb3ccb087086b4b44 commit bc24ac56413d35a83928c20bb3ccb087086b4b44 Author: dschuyler <dschuyler@chromium.org> Date: Wed Apr 12 18:45:34 2017 [MD settings] vertical align left edge of icons and text in ChromeOS People This CL updates the vertical alignment of items on multiples of 60px (the old style was to line up on multiples of 56px). BUG= 710704 , 709654 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2815783002 Cr-Commit-Position: refs/heads/master@{#464096} [modify] https://crrev.com/bc24ac56413d35a83928c20bb3ccb087086b4b44/chrome/browser/resources/settings/people_page/user_list.html [modify] https://crrev.com/bc24ac56413d35a83928c20bb3ccb087086b4b44/chrome/browser/resources/settings/people_page/users_page.html
,
May 8 2017
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by tbuck...@chromium.org
, Apr 10 2017Owner: bettes@chromium.org
Status: Assigned (was: Untriaged)