New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709650 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----



Sign in to add a comment

Remove devserver package in site-packages of autotest?

Project Member Reported by xixuan@chromium.org, Apr 7 2017

Issue description

seems only one function (gsutil_util.GetGSNamesWithWait) in devserver package is used in autotest, and that function has already been replaced by gs.GSContext().GetGsNamesWithWait in chromite.

So possibly we could remove devserver package in site-packages.


 

Comment 1 by xixuan@chromium.org, Aug 16 2017

Cc: vapier@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8fe92ca280428c8abf2524efa38bceb85048bf53

commit 8fe92ca280428c8abf2524efa38bceb85048bf53
Author: xixuan <xixuan@chromium.org>
Date: Fri Aug 18 05:41:10 2017

autotest: Remove devserver gs dependency.

This CL removes the last user for devserver gsutil package.

BUG= chromium:709650 
TEST=Ran test_image.gs_ls(pattern, archive_url, False) locally before/after
changes, and compare the outputs.
Ran unittest.

Change-Id: I91413e6698c80066c85bd48295285e00ad894bdf
Reviewed-on: https://chromium-review.googlesource.com/619496
Commit-Ready: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/8fe92ca280428c8abf2524efa38bceb85048bf53/site_utils/autoupdate/test_image.py
[modify] https://crrev.com/8fe92ca280428c8abf2524efa38bceb85048bf53/site_utils/autoupdate/full_release_test_test.py

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/523638859a12ad816475f859ec33b145e91400a2

commit 523638859a12ad816475f859ec33b145e91400a2
Author: Xixuan Wu <xixuan@chromium.org>
Date: Thu Aug 24 00:01:23 2017

autotest: remove devserver server-side package from site-packages.

BUG= chromium:709650 
TEST=Run ./utils/build_externals.py locally.

Change-Id: I2a7d41bc673195456cfc587bc4d0d023af51e567
Reviewed-on: https://chromium-review.googlesource.com/629157
Commit-Ready: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/523638859a12ad816475f859ec33b145e91400a2/utils/external_packages.py

Comment 4 by xixuan@chromium.org, Mar 19 2018

Status: Fixed (was: Started)

Sign in to add a comment