New issue
Advanced search Search tips

Issue 709633 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature
Team-Accessibility

Blocking:
issue 801429



Sign in to add a comment

[A11y Request] Increase magnification level

Project Member Reported by lpalmaro@chromium.org, Apr 7 2017

Issue description

OS: Chrome 

We have received a handful of requests to be able to increase the zoom level to more than our current level (which I believe is 10x but could be wrong). Other platforms support up to 40X, and provide a way for users to choose the magnification level that works best for their vision. We should increase our max level to up to 40x. 

From here, the user should be able to adjust the level by pressing Ctrl Alt and scrolling two fingers on the trackpad. Or, we could consider having a simple setting for zoom level (perhaps a sliding scale like our new adjustable mouse cursor scale). 
 
Owner: abodenha@chromium.org
Status: Assigned (was: Available)
Cc: lpalmaro@chromium.org
lpalmaro@ can you run this by UI review?

I'm thinking keeping the UX the same but just increasing the upper bound is the simplest solution.  We can consider other ways of controlling it as a separate question.

If Ui review signs off I'm hoping we can do it with a simple change.

Is there any reason to leave this restricted?
Labels: -Restrict-View-Google
Owner: lpalmaro@chromium.org

Comment 4 by katie@chromium.org, Jan 8 2018

Owner: katie@chromium.org
Status: Started (was: Assigned)
Blocking: 801429
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b0879c77d86676a28d6e4334c3bdca0f005f6cb

commit 5b0879c77d86676a28d6e4334c3bdca0f005f6cb
Author: Katie Dektar <katydek@google.com>
Date: Fri Jan 12 22:20:12 2018

Increase ChromeOS screen magnifier maximum, zoom sensitivitiy.

Increases the maximum to 20x (was 4x). Leaves the default as-is.

Also changes scaling logic to make it easier for users to
get fine degrees of control on zoom.

Gives users information on how to control magnification scale
directly from the settings page.

Bug:  709633 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I901d0038c560cac9f147e3d77303807d09a5c614
Reviewed-on: https://chromium-review.googlesource.com/857904
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529083}
[modify] https://crrev.com/5b0879c77d86676a28d6e4334c3bdca0f005f6cb/ash/magnifier/magnification_controller.cc
[modify] https://crrev.com/5b0879c77d86676a28d6e4334c3bdca0f005f6cb/chrome/browser/chromeos/accessibility/magnification_manager_browsertest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d01be1da2799ce25b2ffbabbf4a6b8361d74f728

commit d01be1da2799ce25b2ffbabbf4a6b8361d74f728
Author: Katie Dektar <katydek@google.com>
Date: Wed Jan 17 04:05:55 2018

Fixes magnification when the user scrolls small amounts.

Previously no action appeared to happen when the user made very small
zoom increments. This is because animation was turned on. Turning
off animating when zooming using scroll makes it feel much more
responsive.

Refactor and add comments for linear->exponential scale adjustment.
Also adds a test for scale adjustment.

Bug:  709633 
Change-Id: I19968abe7726c84d407d1f68c977e00c6a8150f3
Reviewed-on: https://chromium-review.googlesource.com/865954
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529593}
[modify] https://crrev.com/d01be1da2799ce25b2ffbabbf4a6b8361d74f728/ash/magnifier/magnification_controller.cc
[modify] https://crrev.com/d01be1da2799ce25b2ffbabbf4a6b8361d74f728/ash/magnifier/magnification_controller.h
[modify] https://crrev.com/d01be1da2799ce25b2ffbabbf4a6b8361d74f728/ash/magnifier/magnification_controller_unittest.cc

Comment 8 by katie@chromium.org, Jan 18 2018

Status: Fixed (was: Started)
This is done, so marking it fixed. Additional bugs for follow-up features, not blocking launch, are:
* increase crispness: crbug.com/801433
* add settings: crbug.com/801429

Comment 9 by katie@chromium.org, Jan 18 2018

Wrong links above
* increase crispness: crbug.com/803552
* add settings: crbug.com/801433

Sign in to add a comment