New issue
Advanced search Search tips

Issue 709622 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 20
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

preserveDrawingBuffer:Discard not implemented in software path

Project Member Reported by sugoi@google.com, Apr 7 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Steps to reproduce the problem:
The following WebGL Conformance Tests 1.0.4 fail in software:

conformance/canvas/buffer-offscreen-test.html
conformance/canvas/buffer-preserve-test.html
conformance/context/context-attribute-preserve-drawing-buffer.html

What is the expected behavior?

What went wrong?
DrawingBuffer::finishPrepareTextureMailboxSoftware currently ignores m_preserveDrawingBuffer.

Did this work before? No 

Chrome version:   Channel: n/a
OS Version: 
Flash Version:
 

Comment 1 by sugoi@chromium.org, Apr 7 2017

Owner: sugoi@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/154a93d5c03f1a483b644c1bca4dea60dabb7dad

commit 154a93d5c03f1a483b644c1bca4dea60dabb7dad
Author: sugoi <sugoi@chromium.org>
Date: Sat Apr 08 13:36:20 2017

Implementation of preserveDrawingBuffer:Discard in software

DrawingBuffer::finishPrepareTextureMailboxSoftware was ignoring the
m_preserveDrawingBuffer setting, so this change adds a simple clear
operation to emulate that behavior in software. Related tests from
the WebGL Conformance Tests 1.0.4 test suite all pass. Tests are:

conformance/canvas/buffer-offscreen-test.html
conformance/canvas/buffer-preserve-test.html
conformance/context/context-attribute-preserve-drawing-buffer.html

BUG= 709622 
R=kbr@chromium.org

Review-Url: https://codereview.chromium.org/2799783008
Cr-Commit-Position: refs/heads/master@{#463132}

[modify] https://crrev.com/154a93d5c03f1a483b644c1bca4dea60dabb7dad/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp

Project Member

Comment 3 by sheriffbot@chromium.org, Jul 20 2017

Labels: Hotlist-Google
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 20

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Archived)

Sign in to add a comment