Incorrect input region for maximized ARC windows |
||||||
Issue descriptionWhen the shelf is positioned to the left, the rightmost area of maximized ARC windows is unresponsive to input.
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef7d5fbdaadfd3c2ed18d662d2ef754e5d208c76 commit ef7d5fbdaadfd3c2ed18d662d2ef754e5d208c76 Author: domlaskowski <domlaskowski@chromium.org> Date: Thu Apr 13 02:06:10 2017 ash: Do not constrain window bounds if requested If a client requests to set window bounds directly, Ash should not interfere, e.g. by constraining them to the workspace size. ARC windows are maximized to the display rather than the workspace. However, Ash would constrain the ShellSurface bounds to the workspace size. As a result, if the shelf was positioned to the left, the right edge of the window would be displaced from that of the display by the width of the shelf, so the app was unresponsive to input in that gap. BUG= 709616 TEST=Print window hierarchy using debug shortcut, and verify that the bounds of a maximized ShellSurface match the display bounds. Review-Url: https://codereview.chromium.org/2806783002 Cr-Commit-Position: refs/heads/master@{#464242} [modify] https://crrev.com/ef7d5fbdaadfd3c2ed18d662d2ef754e5d208c76/ash/wm/default_state.cc [modify] https://crrev.com/ef7d5fbdaadfd3c2ed18d662d2ef754e5d208c76/ash/wm/maximize_mode/maximize_mode_window_manager.cc [modify] https://crrev.com/ef7d5fbdaadfd3c2ed18d662d2ef754e5d208c76/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc [modify] https://crrev.com/ef7d5fbdaadfd3c2ed18d662d2ef754e5d208c76/ash/wm/maximize_mode/maximize_mode_window_state.cc [modify] https://crrev.com/ef7d5fbdaadfd3c2ed18d662d2ef754e5d208c76/ash/wm/window_state.h [modify] https://crrev.com/ef7d5fbdaadfd3c2ed18d662d2ef754e5d208c76/ash/wm/window_state_unittest.cc [modify] https://crrev.com/ef7d5fbdaadfd3c2ed18d662d2ef754e5d208c76/components/exo/shell_surface.cc
,
Apr 13 2017
,
Apr 13 2017
This bug requires manual review: We are only 11 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 13 2017
,
Apr 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d901345e2c36527bc5f4ab8f8237cd92d4766e22 commit d901345e2c36527bc5f4ab8f8237cd92d4766e22 Author: domlaskowski <domlaskowski@chromium.org> Date: Fri Apr 14 18:47:01 2017 [M58] ash: Do not constrain window bounds if requested If a client requests to set window bounds directly, Ash should not interfere, e.g. by constraining them to the workspace size. ARC windows are maximized to the display rather than the workspace. However, Ash would constrain the ShellSurface bounds to the workspace size. As a result, if the shelf was positioned to the left, the right edge of the window would be displaced from that of the display by the width of the shelf, so the app was unresponsive to input in that gap. TBR=oshima@chromium.org,reveman@chromium.org NOTRY=true NOPRESUBMIT=true BUG= 709616 TEST=Print window hierarchy using debug shortcut, and verify that the bounds of a maximized ShellSurface match the display bounds. Review-Url: https://codereview.chromium.org/2822613004 Cr-Commit-Position: refs/branch-heads/3029@{#716} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/d901345e2c36527bc5f4ab8f8237cd92d4766e22/ash/common/wm/default_state.cc [modify] https://crrev.com/d901345e2c36527bc5f4ab8f8237cd92d4766e22/ash/common/wm/maximize_mode/maximize_mode_window_manager.cc [modify] https://crrev.com/d901345e2c36527bc5f4ab8f8237cd92d4766e22/ash/common/wm/maximize_mode/maximize_mode_window_state.cc [modify] https://crrev.com/d901345e2c36527bc5f4ab8f8237cd92d4766e22/ash/common/wm/window_state.h [modify] https://crrev.com/d901345e2c36527bc5f4ab8f8237cd92d4766e22/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc [modify] https://crrev.com/d901345e2c36527bc5f4ab8f8237cd92d4766e22/ash/wm/window_state_unittest.cc [modify] https://crrev.com/d901345e2c36527bc5f4ab8f8237cd92d4766e22/components/exo/shell_surface.cc
,
Apr 14 2017
,
May 11 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by domlasko...@chromium.org
, Apr 10 2017