New issue
Advanced search Search tips

Issue 709605 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 709061



Sign in to add a comment

Use reference parameters in IIRFilterNode

Project Member Reported by rtoy@chromium.org, Apr 7 2017

Issue description

Use reference parameters so we don't copy the arrays around.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b4a31d9f95869f6efc1fee07942eb913140ae5d

commit 4b4a31d9f95869f6efc1fee07942eb913140ae5d
Author: rtoy <rtoy@chromium.org>
Date: Mon Apr 10 22:58:50 2017

Use reference parameters when constructing IIRFilterNode's

Use reference parameters so new copies of Vectors aren't created.

BUG= 709605 
TEST=none; no visible changes

Review-Url: https://codereview.chromium.org/2800203002
Cr-Commit-Position: refs/heads/master@{#463433}

[modify] https://crrev.com/4b4a31d9f95869f6efc1fee07942eb913140ae5d/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp
[modify] https://crrev.com/4b4a31d9f95869f6efc1fee07942eb913140ae5d/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h

Comment 2 by rtoy@chromium.org, Apr 11 2017

Status: Fixed (was: Started)

Sign in to add a comment