[MD Settings] Radio button issues with screen readers |
||||||
Issue descriptionOS: Version: Across platforms: When I navigate to a radio button that is selected, I don't hear the state of selected. I just hear that it's a radio button. Once I actually press space to select it, THEN I hear the state, but I should hear that state when I simply navigate through the radio buttons, as well. The first time you navigate through the radio buttons, it doesn't read "checked" for the checked ones... It just says it's a radio button, so if I couldn't visually see it was checked, I'd think it was unchecked since it didn't read any state (which is the typical behavior for unchecked). Once you actually press space to check one, then it reads the state on Mac, but there seems to be some weirdness when you navigate through the radio buttons but don't change the state of them. Chrome OS: On Chrome OS, I'm noticing a bit of weirdness, too. When I navigate to a radio button group with ChromeVox, I hear "radio button group". If I press Search + Right to move forward linearly after hearing "radio button group", I'd expect to be brought to the first radio button in the group. However, I move past the whole group. I have to press Search + Down (which is line navigation) to get to the radio buttons. Also, on Chrome OS, I am noticing the same thing - when navigating through the radio buttons, I don't hear the state of "checked" or "selected" on the one that is selected. I don't hear states on either... Then, when I press space to select one, I'm actually hearing the wrong thing. When I press space once, I hear "...radio button unselected" (even though I just selected it). Then if I press space again on that same button, it remains selected and then I hear "...radio button selected" which is right. Seems odd. Windows: NVDA: With radio buttons, I'm hearing "radio button not checked" for radio buttons that ARE checked. Again, more weirdness that seems to exist across platforms. When I do check an unchecked radio button, then I don't hear anything. If I press space again, then I hear checked. Same with Jaws. However, if I check a radio button or check box twice, it does work. Same issue when switching to Forms Mode (equivalent to NVDA's Focus Mode) and using cursors to change value of radio buttons. They don't announce as being checked.
,
Apr 7 2017
Looking into this
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6dd419deb677011673257d555f097cbc944adc28 commit 6dd419deb677011673257d555f097cbc944adc28 Author: hcarmona <hcarmona@chromium.org> Date: Tue Apr 11 17:46:34 2017 MD-Settings: A11y - Make sure checked is reflected. R=dbeam@chromium.org BUG= 709579 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2809033002 Cr-Commit-Position: refs/heads/master@{#463677} [modify] https://crrev.com/6dd419deb677011673257d555f097cbc944adc28/chrome/browser/resources/settings/controls/controlled_radio_button.html
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8cc56536e49b90e770e701868a5941ed53a07737 commit 8cc56536e49b90e770e701868a5941ed53a07737 Author: dbeam <dbeam@chromium.org> Date: Wed Apr 12 20:11:28 2017 Revert of MD-Settings: A11y - Make sure checked is reflected. (patchset #1 id:1 of https://codereview.chromium.org/2809033002/ ) Reason for revert: Breaks "On Startup" radio group by allowing the effective value to become unchecked http://i.imgur.com/FUjYU7Q.png Original issue's description: > MD-Settings: A11y - Make sure checked is reflected. > > R=dbeam@chromium.org > BUG= 709579 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2809033002 > Cr-Commit-Position: refs/heads/master@{#463677} > Committed: https://chromium.googlesource.com/chromium/src/+/6dd419deb677011673257d555f097cbc944adc28 TBR=hcarmona@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 709579 Review-Url: https://codereview.chromium.org/2812343002 Cr-Commit-Position: refs/heads/master@{#464128} [modify] https://crrev.com/8cc56536e49b90e770e701868a5941ed53a07737/chrome/browser/resources/settings/controls/controlled_radio_button.html
,
Apr 12 2017
hcarmona@, dpapad@: I'm gonna need a sharp review from you both ;)
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf655c64cc8f79abcffe366fea0358decb03e6fd commit cf655c64cc8f79abcffe366fea0358decb03e6fd Author: dbeam <dbeam@chromium.org> Date: Thu Apr 13 04:14:40 2017 MD Settings: compose a <paper-radio-button> instead of wrapping one in <controlled-radio-button> R=dpapad@chromium.org,hcarmona@chromium.org BUG= 709579 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2816883002 Cr-Commit-Position: refs/heads/master@{#464292} [modify] https://crrev.com/cf655c64cc8f79abcffe366fea0358decb03e6fd/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/cf655c64cc8f79abcffe366fea0358decb03e6fd/chrome/browser/resources/settings/appearance_page/home_url_input.html [modify] https://crrev.com/cf655c64cc8f79abcffe366fea0358decb03e6fd/chrome/browser/resources/settings/controls/compiled_resources2.gyp [modify] https://crrev.com/cf655c64cc8f79abcffe366fea0358decb03e6fd/chrome/browser/resources/settings/controls/controlled_radio_button.html [modify] https://crrev.com/cf655c64cc8f79abcffe366fea0358decb03e6fd/chrome/browser/resources/settings/controls/controlled_radio_button.js [modify] https://crrev.com/cf655c64cc8f79abcffe366fea0358decb03e6fd/chrome/browser/resources/settings/controls/settings_radio_group.js [modify] https://crrev.com/cf655c64cc8f79abcffe366fea0358decb03e6fd/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/cf655c64cc8f79abcffe366fea0358decb03e6fd/chrome/test/data/webui/settings/controlled_radio_button_tests.js
,
Apr 13 2017
,
Apr 18 2017
hey Laura, Dominic, or Nektarios: are radios working as expected now on md-settings?
,
Apr 20 2017
let's called it fixed and see who disagrees ;) |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dbeam@chromium.org
, Apr 7 2017Cc: -hcarmona@chromium.org
Owner: hcarmona@chromium.org
Status: Assigned (was: Available)