MD Settings: toggle buttons read the wrong "deselect/select" action to take |
|||
Issue descriptionI used VoiceOver on Canary. 0. open chrome://md-settings 1. tab to "Show bookmarks bar" toggle button 2. toggle the value via VO+space what do you expect? a useful message about what VO+space would do if performed what happens instead? "deselect toggle button" is read over and over.
,
Apr 11 2017
We were missing a notification for toggle button changes on Mac: https://codereview.chromium.org/2811713006/
,
Apr 11 2017
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd5b263792257e226f31136b15af0341673811d5 commit dd5b263792257e226f31136b15af0341673811d5 Author: dmazzoni <dmazzoni@chromium.org> Date: Tue Apr 11 16:15:37 2017 Fire event on Mac when PRESSED state changes On Mac, toggle buttons are subclasses of checkboxes, so we can handle them the same as when a checkbox changes. This is a great use of the new attribute chance callback infrastructure. BUG= 709572 ,699438 Review-Url: https://codereview.chromium.org/2811713006 Cr-Commit-Position: refs/heads/master@{#463647} [modify] https://crrev.com/dd5b263792257e226f31136b15af0341673811d5/content/browser/accessibility/browser_accessibility_manager_mac.h [modify] https://crrev.com/dd5b263792257e226f31136b15af0341673811d5/content/browser/accessibility/browser_accessibility_manager_mac.mm
,
Jun 28 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dbeam@chromium.org
, Apr 7 2017Owner: dmazz...@chromium.org
Status: Assigned (was: Available)