New issue
Advanced search Search tips

Issue 709571 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Payments] Desktop: editing incomplete items

Project Member Reported by ma...@chromium.org, Apr 7 2017

Issue description

Selecting an incomplete item in the payment/address lists should open the editors to edit those items.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4baea33bdc3f22c101176a43e694cbc1cbb56650

commit 4baea33bdc3f22c101176a43e694cbc1cbb56650
Author: mathp <mathp@chromium.org>
Date: Mon Apr 10 21:42:29 2017

[Payments] Selecting incomplete items will open editors

BUG= 709571 
TEST=browser_tests
TBR=mahmadi

Review-Url: https://codereview.chromium.org/2805263003
Cr-Commit-Position: refs/heads/master@{#463406}

[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/chrome/browser/ui/views/payments/credit_card_editor_view_controller.h
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/chrome/browser/ui/views/payments/credit_card_editor_view_controller_unittest.cc
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/chrome/browser/ui/views/payments/editor_view_controller.cc
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/chrome/browser/ui/views/payments/editor_view_controller.h
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/chrome/browser/ui/views/payments/payment_method_view_controller.cc
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/chrome/browser/ui/views/payments/payment_request_browsertest_base.h
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/chrome/browser/ui/views/payments/payment_request_dialog_view.cc
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/chrome/browser/ui/views/payments/payment_request_dialog_view.h
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/chrome/browser/ui/views/payments/payment_request_payment_response_browsertest.cc
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/chrome/browser/ui/views/payments/profile_list_view_controller.cc
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/components/autofill/core/browser/autofill_test_utils.cc
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/components/payments/content/payment_request_state.cc
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/components/payments/content/payment_request_state_unittest.cc
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/components/payments/core/BUILD.gn
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/components/payments/core/autofill_payment_instrument.cc
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/components/payments/core/autofill_payment_instrument.h
[add] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/components/payments/core/autofill_payment_instrument_unittest.cc
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/components/payments/core/payment_instrument.cc
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/components/payments/core/payment_instrument.h
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/components/payments/core/payment_request_data_util_unittest.cc
[modify] https://crrev.com/4baea33bdc3f22c101176a43e694cbc1cbb56650/ios/chrome/browser/payments/payment_request_coordinator_unittest.mm

Comment 2 by ma...@chromium.org, Apr 11 2017

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24ce4cde5a1d9f21ff63d0560f904dbd2dc46d81

commit 24ce4cde5a1d9f21ff63d0560f904dbd2dc46d81
Author: mathp <mathp@chromium.org>
Date: Wed Apr 12 20:56:42 2017

[Payments] After adding/editing a credit card, instrument is selected.

After being done editing an incomplete card, or adding a new one, the
instrument is selected for payment.

Still TODO is to go back to the payment sheet after the editor has
returned.

BUG= 709571 
TEST=browser_tests

Review-Url: https://codereview.chromium.org/2807363003
Cr-Commit-Position: refs/heads/master@{#464148}

[modify] https://crrev.com/24ce4cde5a1d9f21ff63d0560f904dbd2dc46d81/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
[modify] https://crrev.com/24ce4cde5a1d9f21ff63d0560f904dbd2dc46d81/chrome/browser/ui/views/payments/credit_card_editor_view_controller.h
[modify] https://crrev.com/24ce4cde5a1d9f21ff63d0560f904dbd2dc46d81/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
[modify] https://crrev.com/24ce4cde5a1d9f21ff63d0560f904dbd2dc46d81/chrome/browser/ui/views/payments/credit_card_editor_view_controller_unittest.cc
[modify] https://crrev.com/24ce4cde5a1d9f21ff63d0560f904dbd2dc46d81/chrome/browser/ui/views/payments/payment_method_view_controller.cc
[modify] https://crrev.com/24ce4cde5a1d9f21ff63d0560f904dbd2dc46d81/chrome/browser/ui/views/payments/payment_request_dialog_view.cc
[modify] https://crrev.com/24ce4cde5a1d9f21ff63d0560f904dbd2dc46d81/chrome/browser/ui/views/payments/payment_request_dialog_view.h
[modify] https://crrev.com/24ce4cde5a1d9f21ff63d0560f904dbd2dc46d81/chrome/browser/ui/views/payments/shipping_option_view_controller.cc
[modify] https://crrev.com/24ce4cde5a1d9f21ff63d0560f904dbd2dc46d81/components/payments/content/payment_request_state.cc
[modify] https://crrev.com/24ce4cde5a1d9f21ff63d0560f904dbd2dc46d81/components/payments/content/payment_request_state.h

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9052324d316824ccedb2204bc68b24cce5dc7c6

commit f9052324d316824ccedb2204bc68b24cce5dc7c6
Author: anthonyvd <anthonyvd@chromium.org>
Date: Fri Apr 14 01:44:21 2017

[Web Payments] Add PopMany and Size functions to ViewStack

BUG= 709571 

Review-Url: https://codereview.chromium.org/2817533006
Cr-Commit-Position: refs/heads/master@{#464651}

[modify] https://crrev.com/f9052324d316824ccedb2204bc68b24cce5dc7c6/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
[modify] https://crrev.com/f9052324d316824ccedb2204bc68b24cce5dc7c6/chrome/browser/ui/views/payments/editor_view_controller.cc
[modify] https://crrev.com/f9052324d316824ccedb2204bc68b24cce5dc7c6/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
[modify] https://crrev.com/f9052324d316824ccedb2204bc68b24cce5dc7c6/chrome/browser/ui/views/payments/payment_request_browsertest_base.h
[modify] https://crrev.com/f9052324d316824ccedb2204bc68b24cce5dc7c6/chrome/browser/ui/views/payments/payment_request_dialog_view.cc
[modify] https://crrev.com/f9052324d316824ccedb2204bc68b24cce5dc7c6/chrome/browser/ui/views/payments/payment_request_dialog_view.h
[modify] https://crrev.com/f9052324d316824ccedb2204bc68b24cce5dc7c6/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc
[modify] https://crrev.com/f9052324d316824ccedb2204bc68b24cce5dc7c6/chrome/browser/ui/views/payments/view_stack.cc
[modify] https://crrev.com/f9052324d316824ccedb2204bc68b24cce5dc7c6/chrome/browser/ui/views/payments/view_stack.h
[modify] https://crrev.com/f9052324d316824ccedb2204bc68b24cce5dc7c6/chrome/browser/ui/views/payments/view_stack_unittest.cc

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment