WebKit probe target compile fails on fresh build. |
|||
Issue description
//third_party/WebKit/Source/core/probes:generated includes generated headers from several targets that it doesn't depend on, resulting in a race condition that breaks the build:
[6605/15869] (221.702s) CXX obj/third_party/WebKit/Source/core/probe/generated/CoreProbesImpl.o
../../third_party/WebKit/Source/core/events/AddEventListenerOptionsResolved.h:8:10: fatal error: 'core/events/AddEventListenerOptions.h' file not found
#include "core/events/AddEventListenerOptions.h"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
This is likely not a problem on the Chromium bots, which build incrementally, but affect the Chromecast bots, which do clean builds, in big way.
This can be repro'ed by doing a clean build (easier to repro if not using lots of parallel jobs)
,
Apr 7 2017
Likely a missing dependency.
,
Apr 11 2017
Friendly ping!
,
Apr 11 2017
I'm OOO currently, but I'll try to submit a fix it today. Sorry for the inconvenience.
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63b2fd059db083da191d2dd9c53eb680baf2e010 commit 63b2fd059db083da191d2dd9c53eb680baf2e010 Author: alph <alph@chromium.org> Date: Tue Apr 18 00:06:47 2017 [instrumentation] Fix probe/BUILD.gn dependencies There are two targets. One for generating sources and another for compiling files. BUG= 709568 Review-Url: https://codereview.chromium.org/2807123005 Cr-Commit-Position: refs/heads/master@{#465070} [modify] https://crrev.com/63b2fd059db083da191d2dd9c53eb680baf2e010/third_party/WebKit/Source/core/inspector/BUILD.gn [modify] https://crrev.com/63b2fd059db083da191d2dd9c53eb680baf2e010/third_party/WebKit/Source/core/probe/BUILD.gn [modify] https://crrev.com/63b2fd059db083da191d2dd9c53eb680baf2e010/third_party/WebKit/Source/core/probe/CoreProbes.h [modify] https://crrev.com/63b2fd059db083da191d2dd9c53eb680baf2e010/third_party/WebKit/Source/core/probe/CoreProbes.json5
,
Apr 18 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by s...@chromium.org
, Apr 7 2017