New issue
Advanced search Search tips

Issue 709560 link

Starred by 1 user
Status: Fixed
Owner:
dtrainor@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 699323



Sign in to add a comment

Downloads - Handle opening a completed download leaving the summary notification behind

Project Member Reported by dtrainor@chromium.org, Apr 7 2017 
Chrome Version: M58, M59, Trunk
OS: Android

What steps will reproduce the problem?
(1) Download a file (e.g. a zip file).
(2) Click on the confirmation notification to open the file/go to downloads home.

What is the expected result?
The notification goes away and no other download notification appears.

What happens instead?
The download summary notification "Chrome Downloads" shows up and sticks around.

If this is a downloaded page, the notification might be stuck in the foreground (can't be swiped away).  If this is a downloaded file, the notification should still be swipe-able.  Either way it shouldn't be visible.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce4c38c5b3535bcb4a08cf2771db378aa8f278f9

commit ce4c38c5b3535bcb4a08cf2771db378aa8f278f9
Author: dtrainor <dtrainor@chromium.org>
Date: Sat Apr 08 03:11:56 2017

Workaround for NotificationManager race condition

It looks like we occasionally handle the notification click intent
while the notification is still temporarily there.  This check adds the
notification id of the dying notification to the intent, so we can
ignore it when scanning the existing notifications to see if any still
require us to have our summary notification active.

BUG= 709560 

Review-Url: https://codereview.chromium.org/2805843002
Cr-Commit-Position: refs/heads/master@{#463120}

[modify] https://crrev.com/ce4c38c5b3535bcb4a08cf2771db378aa8f278f9/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastReceiver.java
[modify] https://crrev.com/ce4c38c5b3535bcb4a08cf2771db378aa8f278f9/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/ce4c38c5b3535bcb4a08cf2771db378aa8f278f9/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

Comment 2 by dtrainor@chromium.org, Apr 10 2017

Labels: Merge-Request-58
Status: Fixed (was: Started)
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 10 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 10 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7b3984a7e4bf958d24085c50967156174a35329

commit e7b3984a7e4bf958d24085c50967156174a35329
Author: David Trainor <dtrainor@chromium.org>
Date: Mon Apr 10 18:38:26 2017

Workaround for NotificationManager race condition

It looks like we occasionally handle the notification click intent
while the notification is still temporarily there.  This check adds the
notification id of the dying notification to the intent, so we can
ignore it when scanning the existing notifications to see if any still
require us to have our summary notification active.

BUG= 709560 

Review-Url: https://codereview.chromium.org/2805843002
Cr-Commit-Position: refs/heads/master@{#463120}
(cherry picked from commit ce4c38c5b3535bcb4a08cf2771db378aa8f278f9)

Review-Url: https://codereview.chromium.org/2813723002 .
Cr-Commit-Position: refs/branch-heads/3029@{#649}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/e7b3984a7e4bf958d24085c50967156174a35329/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastReceiver.java
[modify] https://crrev.com/e7b3984a7e4bf958d24085c50967156174a35329/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/e7b3984a7e4bf958d24085c50967156174a35329/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

Comment 5 by prashanthpola@chromium.org, Apr 11 2017 

Verified on Chrome:59.0.3068.1 Device: HTC ONE A9/NRD90M
►

Sign in to add a comment