Add support to "lease" a swarming task |
||||||||
Issue descriptionIt's a frequently requested feature but was not yet implemented because the Swarming bot doesn't know how to pass through NAT routers. Goal: Similar to a 'terminate' task, add a 'lease' task. This task would have a duration associated (24h default?) and could be canceled early by the user or an admin. But unlike 'terminate', the swarming bot process wouldn't terminate, it would put itself to sleep with periodic poll to determine if the lease was canceled. Open questions: - How a dev is supposed to access the bots. Other services open a temporary ssh server or other mechanism. We can't assume the worker is externally accessible and the Swarming server itself cannot act as a proxy. - Security wise, the group that have access to lease bots are privileged users or create a new independent group? Likely the later.
,
Oct 19 2017
A Skia specific feature request is isssue skia:7098. There's multiple facets here, some are where Machine Provider ough to give a plain VM but not all machines are managed by MP at the moment, so either we make this a forcing function or we keep it at the Swarming level. There are precedent, a good example is the Go CI system. We'd probably want it at the Swarming level so that the tree would be mapped in, which in some cases, like Windows and OSX, is really important to be able to RDP in to see what happened in the UI. Having a debugger ready would be a nice to have too. I'll keep it focused on Swarming because of this. This doesn't preclude a pure MP lease Web UI. Raising priority because this request constantly comes back.
,
Oct 24 2017
,
Oct 25 2017
Duplicate of 589982 ?
,
Oct 25 2017
Issue 589982 is about grabbing a bot. I renamed this issue to be focused on "grabbing a task". I'm thinking about not implementing the "grab a bot" at all after all.
,
Oct 25 2017
,
Oct 25 2017
Issue 589982 has been merged into this issue.
,
Oct 25 2017
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/0f778293df7bafe1f0b0b44931f65dc638113a3b commit 0f778293df7bafe1f0b0b44931f65dc638113a3b Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Wed Oct 25 17:54:53 2017 Add debug_task.py to trigger a debug task. Bug: 709557 Change-Id: Ib071f7395cec76a87cba0eded9a881d3068bba76 Reviewed-on: https://chromium-review.googlesource.com/736371 Reviewed-by: Benjamin Pastene <bpastene@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> [add] https://crrev.com/0f778293df7bafe1f0b0b44931f65dc638113a3b/client/tools/debug_task.py
,
Oct 25 2017
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/ed1fd851ab0de84771c35d7a1dd04a2d573bab1a commit ed1fd851ab0de84771c35d7a1dd04a2d573bab1a Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Wed Oct 25 18:21:40 2017 Fix the debug_task.py generated task url Had forgot to confirm it was the valid format. Bug: 709557 Change-Id: Ida41a5fde48d63ccee8b6f00e13f7c639f9b6da6 Reviewed-on: https://chromium-review.googlesource.com/737421 Reviewed-by: Benjamin Pastene <bpastene@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/ed1fd851ab0de84771c35d7a1dd04a2d573bab1a/client/tools/debug_task.py
,
Oct 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/34f349c8680d63efb269f2a150de3471943a047c commit 34f349c8680d63efb269f2a150de3471943a047c Author: Peter Ward <flowblok@chromium.org> Date: Sat Oct 28 00:47:16 2017 Add UI for triggering a debug task. Bug: 709557 Change-Id: Ibbee493381b1058978e7310091655af726b39d81 Reviewed-on: https://chromium-review.googlesource.com/736950 Commit-Queue: flowblok <flowblok@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Kevin Lubick <kjlubick@chromium.org> [modify] https://crrev.com/34f349c8680d63efb269f2a150de3471943a047c/appengine/swarming/ui/build/elements.html [modify] https://crrev.com/34f349c8680d63efb269f2a150de3471943a047c/appengine/swarming/ui/build/js/js.js [modify] https://crrev.com/34f349c8680d63efb269f2a150de3471943a047c/appengine/swarming/ui/res/imp/taskpage/task-page.html [modify] https://crrev.com/34f349c8680d63efb269f2a150de3471943a047c/appengine/swarming/ui/res/imp/taskpage/task-retry-prompt.html [modify] https://crrev.com/34f349c8680d63efb269f2a150de3471943a047c/appengine/swarming/ui/res/js/common.js
,
Nov 1 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/194aa3d0d92c58b5f5663c8e17850c0c9fd88df6 commit 194aa3d0d92c58b5f5663c8e17850c0c9fd88df6 Author: Benjamin Pastene <bpastene@chromium.org> Date: Wed Nov 01 19:34:12 2017
,
Nov 2 2017
\o/ Will not mark as fixed yet because of the Retry button regression.
,
Nov 8 2017
I can repro the retry button regression. I'll have a fix in soon, hopefully.
,
Nov 9 2017
Fix in https://chromium-review.googlesource.com/c/infra/luci/luci-py/+/758880 has been deployed to chromium-swarm(-dev)? and chrome-swarming
,
Nov 9 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/68746c5ac2017920e99a2a77e78b984f0de53598 commit 68746c5ac2017920e99a2a77e78b984f0de53598 Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Thu Nov 09 19:38:34 2017 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by estaab@chromium.org
, Jun 20 2017