New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709543 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Suspicious changes detecting

Project Member Reported by nxia@chromium.org, Apr 7 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/4c12c22551e64577e46778ee0fd262d4f6fbe059

commit 4c12c22551e64577e46778ee0fd262d4f6fbe059
Author: Ningning Xia <nxia@chromium.org>
Date: Wed May 03 20:01:33 2017

Add hwTestResultTable in cidb.

BUG= chromium:709543 
TEST=cidb_integration_test

Change-Id: If2dff807c139108ae8f012ccc78d0ff4eea0299a
Reviewed-on: https://chromium-review.googlesource.com/494029
Trybot-Ready: Ningning Xia <nxia@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Commit-Queue: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/4c12c22551e64577e46778ee0fd262d4f6fbe059/cidb/schema.dump
[add] https://crrev.com/4c12c22551e64577e46778ee0fd262d4f6fbe059/cidb/migrations/00057_create_hwtest_result_table.sql

Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b56f1742172714a9b81bf30dc5ae33c74539efc8

commit b56f1742172714a9b81bf30dc5ae33c74539efc8
Author: Ningning Xia <nxia@chromium.org>
Date: Thu May 11 03:58:05 2017

Add Insert and Get methods for hwTestResultTable in CIDB

BUG= chromium:709543 
TEST=lib/cidb_integration_test

Change-Id: Ieac19518c15982db458ca078a120379f9c689840
Reviewed-on: https://chromium-review.googlesource.com/495846
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[add] https://crrev.com/b56f1742172714a9b81bf30dc5ae33c74539efc8/lib/hwtest_results.py
[modify] https://crrev.com/b56f1742172714a9b81bf30dc5ae33c74539efc8/lib/cidb.py
[modify] https://crrev.com/b56f1742172714a9b81bf30dc5ae33c74539efc8/lib/cidb_integration_test.py

Project Member

Comment 3 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a44f64569293e6bdc9202f0ac3ce0dd3315594eb

commit a44f64569293e6bdc9202f0ac3ce0dd3315594eb
Author: Ningning Xia <nxia@chromium.org>
Date: Thu May 18 02:06:20 2017

Support finding suspects for HWTest failures.

When the build failures are neither pure lab failures nor pure infra
failures, analyze every failure message, find suspects for
PackageBuildFailures and HWTestFailures and reject the suspects.
When sanity is true and some failures don't have assigned suspects,
treat all changes as suspects and reject them all.

BUG= chromium:709543 
TEST=unit_tests

Change-Id: I12235d2ff0006479c32080122479b8b13f61ec54
Reviewed-on: https://chromium-review.googlesource.com/501488
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/a44f64569293e6bdc9202f0ac3ce0dd3315594eb/cbuildbot/validation_pool.py
[modify] https://crrev.com/a44f64569293e6bdc9202f0ac3ce0dd3315594eb/lib/failure_message_lib_unittest.py
[modify] https://crrev.com/a44f64569293e6bdc9202f0ac3ce0dd3315594eb/lib/triage_lib_unittest.py
[modify] https://crrev.com/a44f64569293e6bdc9202f0ac3ce0dd3315594eb/lib/hwtest_results_unittest.py
[modify] https://crrev.com/a44f64569293e6bdc9202f0ac3ce0dd3315594eb/lib/hwtest_results.py
[modify] https://crrev.com/a44f64569293e6bdc9202f0ac3ce0dd3315594eb/lib/triage_lib.py
[modify] https://crrev.com/a44f64569293e6bdc9202f0ac3ce0dd3315594eb/lib/failure_message_lib.py

Project Member

Comment 4 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/147205c96a473b74e8b22909eecc3106807153ee

commit 147205c96a473b74e8b22909eecc3106807153ee
Author: Ningning Xia <nxia@chromium.org>
Date: Thu May 18 22:17:32 2017

Revert "Support finding suspects for HWTest failures."

This reverts commit a44f64569293e6bdc9202f0ac3ce0dd3315594eb.

Reason for revert: chromium:724269

Original change's description:
> Support finding suspects for HWTest failures.
> 
> When the build failures are neither pure lab failures nor pure infra
> failures, analyze every failure message, find suspects for
> PackageBuildFailures and HWTestFailures and reject the suspects.
> When sanity is true and some failures don't have assigned suspects,
> treat all changes as suspects and reject them all.
> 
> BUG= chromium:709543 
> TEST=unit_tests
> 
> Change-Id: I12235d2ff0006479c32080122479b8b13f61ec54
> Reviewed-on: https://chromium-review.googlesource.com/501488
> Commit-Ready: Ningning Xia <nxia@chromium.org>
> Tested-by: Ningning Xia <nxia@chromium.org>
> Reviewed-by: Aviv Keshet <akeshet@chromium.org>
> 

BUG= chromium:709543 

Change-Id: Ib6da89570fc7ffc6ab3f331596bf9fe208420347
Reviewed-on: https://chromium-review.googlesource.com/508244
Trybot-Ready: Ningning Xia <nxia@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Commit-Queue: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/cbuildbot/validation_pool.py
[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/lib/failure_message_lib_unittest.py
[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/lib/triage_lib_unittest.py
[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/lib/hwtest_results_unittest.py
[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/lib/hwtest_results.py
[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/lib/triage_lib.py
[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/lib/failure_message_lib.py

Project Member

Comment 5 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/147205c96a473b74e8b22909eecc3106807153ee

commit 147205c96a473b74e8b22909eecc3106807153ee
Author: Ningning Xia <nxia@chromium.org>
Date: Thu May 18 22:17:32 2017

Revert "Support finding suspects for HWTest failures."

This reverts commit a44f64569293e6bdc9202f0ac3ce0dd3315594eb.

Reason for revert: chromium:724269

Original change's description:
> Support finding suspects for HWTest failures.
> 
> When the build failures are neither pure lab failures nor pure infra
> failures, analyze every failure message, find suspects for
> PackageBuildFailures and HWTestFailures and reject the suspects.
> When sanity is true and some failures don't have assigned suspects,
> treat all changes as suspects and reject them all.
> 
> BUG= chromium:709543 
> TEST=unit_tests
> 
> Change-Id: I12235d2ff0006479c32080122479b8b13f61ec54
> Reviewed-on: https://chromium-review.googlesource.com/501488
> Commit-Ready: Ningning Xia <nxia@chromium.org>
> Tested-by: Ningning Xia <nxia@chromium.org>
> Reviewed-by: Aviv Keshet <akeshet@chromium.org>
> 

BUG= chromium:709543 

Change-Id: Ib6da89570fc7ffc6ab3f331596bf9fe208420347
Reviewed-on: https://chromium-review.googlesource.com/508244
Trybot-Ready: Ningning Xia <nxia@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Commit-Queue: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/cbuildbot/validation_pool.py
[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/lib/failure_message_lib_unittest.py
[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/lib/triage_lib_unittest.py
[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/lib/hwtest_results_unittest.py
[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/lib/hwtest_results.py
[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/lib/triage_lib.py
[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/lib/failure_message_lib.py

Project Member

Comment 6 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/147205c96a473b74e8b22909eecc3106807153ee

commit 147205c96a473b74e8b22909eecc3106807153ee
Author: Ningning Xia <nxia@chromium.org>
Date: Thu May 18 22:17:32 2017

Revert "Support finding suspects for HWTest failures."

This reverts commit a44f64569293e6bdc9202f0ac3ce0dd3315594eb.

Reason for revert: chromium:724269

Original change's description:
> Support finding suspects for HWTest failures.
> 
> When the build failures are neither pure lab failures nor pure infra
> failures, analyze every failure message, find suspects for
> PackageBuildFailures and HWTestFailures and reject the suspects.
> When sanity is true and some failures don't have assigned suspects,
> treat all changes as suspects and reject them all.
> 
> BUG= chromium:709543 
> TEST=unit_tests
> 
> Change-Id: I12235d2ff0006479c32080122479b8b13f61ec54
> Reviewed-on: https://chromium-review.googlesource.com/501488
> Commit-Ready: Ningning Xia <nxia@chromium.org>
> Tested-by: Ningning Xia <nxia@chromium.org>
> Reviewed-by: Aviv Keshet <akeshet@chromium.org>
> 

BUG= chromium:709543 

Change-Id: Ib6da89570fc7ffc6ab3f331596bf9fe208420347
Reviewed-on: https://chromium-review.googlesource.com/508244
Trybot-Ready: Ningning Xia <nxia@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Commit-Queue: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/cbuildbot/validation_pool.py
[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/lib/failure_message_lib_unittest.py
[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/lib/triage_lib_unittest.py
[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/lib/hwtest_results_unittest.py
[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/lib/hwtest_results.py
[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/lib/triage_lib.py
[modify] https://crrev.com/147205c96a473b74e8b22909eecc3106807153ee/lib/failure_message_lib.py

Project Member

Comment 7 by bugdroid1@chromium.org, May 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f578c9bcb1c65ea013dc70579559f0d3f7941cbf

commit f578c9bcb1c65ea013dc70579559f0d3f7941cbf
Author: Ningning Xia <nxia@chromium.org>
Date: Sat May 20 10:55:15 2017

Reland "Support finding suspects for HWTest failures."

This reverts commit 147205c96a473b74e8b22909eecc3106807153ee.

Reason for revert: not the root cause for chromium:724269

BUG= chromium:709543 
TEST=None

Original change's description:
> Revert "Support finding suspects for HWTest failures."
>
> This reverts commit a44f64569293e6bdc9202f0ac3ce0dd3315594eb.
>
> Reason for revert: chromium:724269
>
> Original change's description:
> > Support finding suspects for HWTest failures.
> >
> > When the build failures are neither pure lab failures nor pure infra
> > failures, analyze every failure message, find suspects for
> > PackageBuildFailures and HWTestFailures and reject the suspects.
> > When sanity is true and some failures don't have assigned suspects,
> > treat all changes as suspects and reject them all.
> >
> > BUG= chromium:709543 
> > TEST=unit_tests
> >
> > Change-Id: I12235d2ff0006479c32080122479b8b13f61ec54
> > Reviewed-on: https://chromium-review.googlesource.com/501488
> > Commit-Ready: Ningning Xia <nxia@chromium.org>
> > Tested-by: Ningning Xia <nxia@chromium.org>
> > Reviewed-by: Aviv Keshet <akeshet@chromium.org>
> >
>
> BUG= chromium:709543 
>
> Change-Id: Ib6da89570fc7ffc6ab3f331596bf9fe208420347
> Reviewed-on: https://chromium-review.googlesource.com/508244
> Trybot-Ready: Ningning Xia <nxia@chromium.org>
> Reviewed-by: Aviv Keshet <akeshet@chromium.org>
> Tested-by: Ningning Xia <nxia@chromium.org>
> Commit-Queue: Ningning Xia <nxia@chromium.org>
>

BUG= chromium:709543 

Change-Id: I8c666cd9fef775a73c503e9390e45f2687ecc939
Reviewed-on: https://chromium-review.googlesource.com/508968
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/f578c9bcb1c65ea013dc70579559f0d3f7941cbf/cbuildbot/validation_pool.py
[modify] https://crrev.com/f578c9bcb1c65ea013dc70579559f0d3f7941cbf/lib/failure_message_lib_unittest.py
[modify] https://crrev.com/f578c9bcb1c65ea013dc70579559f0d3f7941cbf/lib/triage_lib_unittest.py
[modify] https://crrev.com/f578c9bcb1c65ea013dc70579559f0d3f7941cbf/lib/hwtest_results_unittest.py
[modify] https://crrev.com/f578c9bcb1c65ea013dc70579559f0d3f7941cbf/lib/hwtest_results.py
[modify] https://crrev.com/f578c9bcb1c65ea013dc70579559f0d3f7941cbf/lib/triage_lib.py
[modify] https://crrev.com/f578c9bcb1c65ea013dc70579559f0d3f7941cbf/lib/failure_message_lib.py

Project Member

Comment 8 by bugdroid1@chromium.org, May 26 2017

Comment 9 by nxia@chromium.org, Jun 21 2017

Status: Fixed (was: Untriaged)

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/0ad455670aac1a83c4b58d641e798ba5dbeb5f59

commit 0ad455670aac1a83c4b58d641e798ba5dbeb5f59
Author: Ningning Xia <nxia@chromium.org>
Date: Thu May 11 03:58:05 2017

Add HWTestResultManager to operate hwtest results

Record HWTestResults for paladin builds.
Collect HWTestResults from CIDB for CQ master build.

BUG= chromium:709543 
TEST=unit_tests

Change-Id: I8c5d8baf803edb308810068694fdba2e7a3c62ea
Reviewed-on: https://chromium-review.googlesource.com/497295
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/0ad455670aac1a83c4b58d641e798ba5dbeb5f59/cbuildbot/validation_pool.py
[modify] https://crrev.com/0ad455670aac1a83c4b58d641e798ba5dbeb5f59/cbuildbot/stages/test_stages_unittest.py
[modify] https://crrev.com/0ad455670aac1a83c4b58d641e798ba5dbeb5f59/cbuildbot/stages/completion_stages.py
[add] https://crrev.com/0ad455670aac1a83c4b58d641e798ba5dbeb5f59/lib/hwtest_results_unittest
[modify] https://crrev.com/0ad455670aac1a83c4b58d641e798ba5dbeb5f59/cbuildbot/stages/completion_stages_unittest.py
[modify] https://crrev.com/0ad455670aac1a83c4b58d641e798ba5dbeb5f59/lib/fake_cidb.py
[add] https://crrev.com/0ad455670aac1a83c4b58d641e798ba5dbeb5f59/lib/hwtest_results_unittest.py
[modify] https://crrev.com/0ad455670aac1a83c4b58d641e798ba5dbeb5f59/lib/hwtest_results.py
[modify] https://crrev.com/0ad455670aac1a83c4b58d641e798ba5dbeb5f59/cbuildbot/stages/test_stages.py
[modify] https://crrev.com/0ad455670aac1a83c4b58d641e798ba5dbeb5f59/lib/constants.py

Sign in to add a comment