This is the tracking bug for the Contact Info Editor on Desktop PaymentRequest.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27028d78159cff5447dd3f98c5da756c91c65658 commit 27028d78159cff5447dd3f98c5da756c91c65658 Author: tmartino <tmartino@chromium.org> Date: Mon Apr 24 16:56:34 2017 [WebPayments] Desktop implementation of Contact Editor BUG= 709535 Review-Url: https://codereview.chromium.org/2816083002 Cr-Commit-Position: refs/heads/master@{#466662} [modify] https://crrev.com/27028d78159cff5447dd3f98c5da756c91c65658/chrome/browser/ui/BUILD.gn [add] https://crrev.com/27028d78159cff5447dd3f98c5da756c91c65658/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc [add] https://crrev.com/27028d78159cff5447dd3f98c5da756c91c65658/chrome/browser/ui/views/payments/contact_info_editor_view_controller.h [add] https://crrev.com/27028d78159cff5447dd3f98c5da756c91c65658/chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc [modify] https://crrev.com/27028d78159cff5447dd3f98c5da756c91c65658/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc [modify] https://crrev.com/27028d78159cff5447dd3f98c5da756c91c65658/chrome/browser/ui/views/payments/payment_request_browsertest_base.h [modify] https://crrev.com/27028d78159cff5447dd3f98c5da756c91c65658/chrome/browser/ui/views/payments/payment_request_dialog_view.cc [modify] https://crrev.com/27028d78159cff5447dd3f98c5da756c91c65658/chrome/browser/ui/views/payments/payment_request_dialog_view.h [modify] https://crrev.com/27028d78159cff5447dd3f98c5da756c91c65658/chrome/browser/ui/views/payments/profile_list_view_controller.cc [modify] https://crrev.com/27028d78159cff5447dd3f98c5da756c91c65658/chrome/browser/ui/views/payments/profile_list_view_controller.h [modify] https://crrev.com/27028d78159cff5447dd3f98c5da756c91c65658/chrome/test/BUILD.gn [modify] https://crrev.com/27028d78159cff5447dd3f98c5da756c91c65658/chrome/test/data/payments/contact_details.js [modify] https://crrev.com/27028d78159cff5447dd3f98c5da756c91c65658/components/autofill/core/browser/validation.cc [modify] https://crrev.com/27028d78159cff5447dd3f98c5da756c91c65658/components/autofill/core/browser/validation.h [modify] https://crrev.com/27028d78159cff5447dd3f98c5da756c91c65658/components/payments_strings.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3c76e76638e0e8d9046b2a95a7f485f4a44ae15 commit f3c76e76638e0e8d9046b2a95a7f485f4a44ae15 Author: Anthony Vallee-Dubois <anthonyvd@chromium.org> Date: Mon May 15 12:15:10 2017 [Web Payments] Select the edited/added profile from the contact editor Bug: 709535 Change-Id: Ia976d2d9a83b25c0527c69a0994546b2c7fe5f94 Reviewed-on: https://chromium-review.googlesource.com/504907 Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#471733} [modify] https://crrev.com/f3c76e76638e0e8d9046b2a95a7f485f4a44ae15/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc [modify] https://crrev.com/f3c76e76638e0e8d9046b2a95a7f485f4a44ae15/chrome/browser/ui/views/payments/contact_info_editor_view_controller.h [modify] https://crrev.com/f3c76e76638e0e8d9046b2a95a7f485f4a44ae15/chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc [modify] https://crrev.com/f3c76e76638e0e8d9046b2a95a7f485f4a44ae15/chrome/browser/ui/views/payments/payment_request_dialog_view.cc [modify] https://crrev.com/f3c76e76638e0e8d9046b2a95a7f485f4a44ae15/chrome/browser/ui/views/payments/payment_request_dialog_view.h [modify] https://crrev.com/f3c76e76638e0e8d9046b2a95a7f485f4a44ae15/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc [modify] https://crrev.com/f3c76e76638e0e8d9046b2a95a7f485f4a44ae15/chrome/browser/ui/views/payments/profile_list_view_controller.cc [modify] https://crrev.com/f3c76e76638e0e8d9046b2a95a7f485f4a44ae15/components/payments/content/payment_request_state.cc [modify] https://crrev.com/f3c76e76638e0e8d9046b2a95a7f485f4a44ae15/components/payments/content/payment_request_state.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40815abd7cd581261a5ca5f92f32cf13c15939ef commit 40815abd7cd581261a5ca5f92f32cf13c15939ef Author: Justin Donnelly <jdonnelly@chromium.org> Date: Mon May 15 14:45:06 2017 Revert "[Web Payments] Select the edited/added profile from the contact editor" This reverts commit f3c76e76638e0e8d9046b2a95a7f485f4a44ae15. Reason for revert: New test failed on Mac10.12 Tests bot. See https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.12%20Tests/builds/523. Original change's description: > [Web Payments] Select the edited/added profile from the contact editor > > Bug: 709535 > Change-Id: Ia976d2d9a83b25c0527c69a0994546b2c7fe5f94 > Reviewed-on: https://chromium-review.googlesource.com/504907 > Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org> > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#471733} TBR=mathp@chromium.org,anthonyvd@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 709535 Change-Id: I8eb7af110928fe574e0112038d80e06e70befc73 Reviewed-on: https://chromium-review.googlesource.com/506028 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#471758} [modify] https://crrev.com/40815abd7cd581261a5ca5f92f32cf13c15939ef/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc [modify] https://crrev.com/40815abd7cd581261a5ca5f92f32cf13c15939ef/chrome/browser/ui/views/payments/contact_info_editor_view_controller.h [modify] https://crrev.com/40815abd7cd581261a5ca5f92f32cf13c15939ef/chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc [modify] https://crrev.com/40815abd7cd581261a5ca5f92f32cf13c15939ef/chrome/browser/ui/views/payments/payment_request_dialog_view.cc [modify] https://crrev.com/40815abd7cd581261a5ca5f92f32cf13c15939ef/chrome/browser/ui/views/payments/payment_request_dialog_view.h [modify] https://crrev.com/40815abd7cd581261a5ca5f92f32cf13c15939ef/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc [modify] https://crrev.com/40815abd7cd581261a5ca5f92f32cf13c15939ef/chrome/browser/ui/views/payments/profile_list_view_controller.cc [modify] https://crrev.com/40815abd7cd581261a5ca5f92f32cf13c15939ef/components/payments/content/payment_request_state.cc [modify] https://crrev.com/40815abd7cd581261a5ca5f92f32cf13c15939ef/components/payments/content/payment_request_state.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1e88b4b1c074c01ee257ffb8a4934fbe88a56eb commit f1e88b4b1c074c01ee257ffb8a4934fbe88a56eb Author: Anthony Vallee-Dubois <anthonyvd@chromium.org> Date: Mon May 15 17:22:52 2017 [Web Payments] Select the edited/added profile from the contact editor This is a reland of https://chromium-review.googlesource.com/c/504907/ which fixes the flaky test that led to the revert. The 2 profiles created by the test were racing to be saved asynchronously, which could cause the profile name expectations to fail. Since the names aren't relevant in that test case, those assertions are removed for the reland and the test relies on the selected profile and the other fields instead. Bug: 709535 Change-Id: I449af7dd2c3ed3644fd1da47774ae73d089490d5 Reviewed-on: https://chromium-review.googlesource.com/506267 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#471813} [modify] https://crrev.com/f1e88b4b1c074c01ee257ffb8a4934fbe88a56eb/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc [modify] https://crrev.com/f1e88b4b1c074c01ee257ffb8a4934fbe88a56eb/chrome/browser/ui/views/payments/contact_info_editor_view_controller.h [modify] https://crrev.com/f1e88b4b1c074c01ee257ffb8a4934fbe88a56eb/chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc [modify] https://crrev.com/f1e88b4b1c074c01ee257ffb8a4934fbe88a56eb/chrome/browser/ui/views/payments/payment_request_dialog_view.cc [modify] https://crrev.com/f1e88b4b1c074c01ee257ffb8a4934fbe88a56eb/chrome/browser/ui/views/payments/payment_request_dialog_view.h [modify] https://crrev.com/f1e88b4b1c074c01ee257ffb8a4934fbe88a56eb/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc [modify] https://crrev.com/f1e88b4b1c074c01ee257ffb8a4934fbe88a56eb/chrome/browser/ui/views/payments/profile_list_view_controller.cc [modify] https://crrev.com/f1e88b4b1c074c01ee257ffb8a4934fbe88a56eb/components/payments/content/payment_request_state.cc [modify] https://crrev.com/f1e88b4b1c074c01ee257ffb8a4934fbe88a56eb/components/payments/content/payment_request_state.h
Comment 1 by tmartino@chromium.org
, Apr 7 2017Labels: OS-Chrome OS-Linux OS-Mac OS-Windows