New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709511 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Suggestion - Add gerrit code review entries to rietveld

Project Member Reported by dtrainor@chromium.org, Apr 7 2017

Issue description

I have a few people who have migrated over to the new gerrit code review tool, but a majority of my code reviews are currently only on rietveld.

Could we have it so one tool or the other shows all of the code reviews for both?  Clicking on the link would obviously open the CL in the appropriate tool, but at least one unified list of the CLs I need to review would be great.

Adding agable@ for triage or suggestions.  Thanks! :)
 
Yeah, that would be awesome!

I assume there are time constraints here, and recently more work has been going on with gerrit, there might be more knowledge around how that code base and auth works, so maybe if you were to choose a single place for the list, maybe in gerrit?

Comment 2 by agable@google.com, Apr 7 2017

Yeah unfortunately this would be such a large body of effort in Rietveld that it simply isn't worth it. We could add a static link to the top of the Rietveld dashboard that says "see if you have reviews on gerrit here" or something, but making a bunch of API calls and formatting the result to look like the rest of the Rietveld dashboard is simply out of scope for a doomed product.

Adding it to gerrit might be more feasible, but only as a plugin, and the dashboard page doesn't support plugins.

Comment 3 by aga...@chromium.org, Apr 12 2017

Cc: aga...@chromium.org andyb...@chromium.org rmis...@chromium.org
Owner: ----
Adding some folks who have done work on both gerrit and rietveld. Do you agree with my assessment that this, although awesome, is out of feasible scope?

Comment 4 by rmis...@google.com, Apr 12 2017

When we (Skia) dogfooded and then migrated completely to Gerrit we ran into the same problem, but it wasn't too bad. Had to check two systems for a while but notification emails made it manageable because it would take you to the right system when you click on the links in it.
It is a good idea and if it was simple to do it should be done. But since it is quite complicated to implement I agree that it is out of feasible scope.
Status: Available (was: Untriaged)
Status: WontFix (was: Available)
Unfortunately I believe that this is sufficiently complex to be infeasible on any time scale. I'm going to close this. If someone feels strongly otherwise, I'm happy to discuss and re-open but for now I think this isn't worth keeping around in our queues and dashboards.

Sign in to add a comment