[Article suggestions] Add UMA metrics for experiments with downloading publisher's favicons |
|||
Issue descriptionWe want to experiment with another favicon server. We should add UMA histograms to measure: Cache hit info: - overall hit rate for the icons for article publishers Cache miss info: (needs to be logged on the places in the code) - success rate to actually download the icon - time to get the response back from the server General measurements about downloads in LargeIconService - pixel size of the favicon downloaded - pixel size of the favicon that produces a FallbackStyle.
,
Apr 10 2017
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8a55f4294d92eeb88331c93dea8503bc6c2945e commit b8a55f4294d92eeb88331c93dea8503bc6c2945e Author: jkrcal <jkrcal@chromium.org> Date: Tue Apr 11 19:34:30 2017 [LargeIconService] Report size of the downloaded favicon to UMA This CL adds UMA metrics for sizes of favicons downloaded from google favicon server. BUG= 709498 Review-Url: https://codereview.chromium.org/2804283003 Cr-Commit-Position: refs/heads/master@{#463726} [modify] https://crrev.com/b8a55f4294d92eeb88331c93dea8503bc6c2945e/components/favicon/core/large_icon_service.cc [modify] https://crrev.com/b8a55f4294d92eeb88331c93dea8503bc6c2945e/components/favicon/core/large_icon_service_unittest.cc [modify] https://crrev.com/b8a55f4294d92eeb88331c93dea8503bc6c2945e/tools/metrics/histograms/histograms.xml
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f0f424e645a9b8209244256f9a7d8bdb1b4e035 commit 5f0f424e645a9b8209244256f9a7d8bdb1b4e035 Author: jkrcal <jkrcal@chromium.org> Date: Thu Apr 13 09:49:44 2017 [LargeIconService] Report size of favicon for fallback style to UMA This CL adds UMA metrics for sizes of favicons from which fallback style was generated (because large enough icon is missing). This is important for evaluating if changing the minimum size limit / using more advanced method for upscaling would help. BUG= 709498 Review-Url: https://codereview.chromium.org/2809783003 Cr-Commit-Position: refs/heads/master@{#464363} [modify] https://crrev.com/5f0f424e645a9b8209244256f9a7d8bdb1b4e035/components/favicon/core/large_icon_service.cc [modify] https://crrev.com/5f0f424e645a9b8209244256f9a7d8bdb1b4e035/components/favicon/core/large_icon_service_unittest.cc [modify] https://crrev.com/5f0f424e645a9b8209244256f9a7d8bdb1b4e035/tools/metrics/histograms/histograms.xml
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08d79b5a7dd7bbaaec2f4ec5ad68de3ed63d58c1 commit 08d79b5a7dd7bbaaec2f4ec5ad68de3ed63d58c1 Author: jkrcal <jkrcal@chromium.org> Date: Thu Apr 13 14:02:11 2017 [Remote suggestions] Log favicon fetch result for both code paths We have two code paths that download favicons from different favicon servers. We can switch between them based on a field trial feature. This CL adds logging of success rates for both the code-paths. BUG= 709498 Review-Url: https://codereview.chromium.org/2812243002 Cr-Commit-Position: refs/heads/master@{#464395} [modify] https://crrev.com/08d79b5a7dd7bbaaec2f4ec5ad68de3ed63d58c1/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java [modify] https://crrev.com/08d79b5a7dd7bbaaec2f4ec5ad68de3ed63d58c1/components/ntp_snippets/BUILD.gn [modify] https://crrev.com/08d79b5a7dd7bbaaec2f4ec5ad68de3ed63d58c1/components/ntp_snippets/content_suggestions_service.cc [modify] https://crrev.com/08d79b5a7dd7bbaaec2f4ec5ad68de3ed63d58c1/tools/metrics/histograms/histograms.xml
,
Apr 18 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jkrcal@chromium.org
, Apr 7 2017