New issue
Advanced search Search tips

Issue 709491 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: ----
Type: ----



Sign in to add a comment

chrome_public_test_apk failing on chromium.android/Marshmallow Tablet Tester

Project Member Reported by hanxi@chromium.org, Apr 7 2017

Issue description

chrome_public_test_apk failing on chromium.android/Marshmallow Tablet Tester

Builders failed on: 
- Marshmallow Tablet Tester: 

The first failure was:
https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/8026

The print stack is:
C 1278.416s Main  [FAIL] org.chromium.chrome.browser.payments.PaymentRequestFreeShippingTest#testAddAddressAndPay:
C 1278.416s Main  java.lang.RuntimeException: Exception occured while waiting for runnable
C 1278.417s Main  	at org.chromium.base.ThreadUtils.runOnUiThreadBlocking(ThreadUtils.java:79)
C 1278.417s Main  	at org.chromium.chrome.browser.payments.PaymentRequestTestBase.setTextInEditorAndWait(PaymentRequestTestBase.java:591)
C 1278.417s Main  	at org.chromium.chrome.browser.payments.PaymentRequestFreeShippingTest.testAddAddressAndPay(PaymentRequestFreeShippingTest.java:80)
C 1278.417s Main  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C 1278.417s Main  	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C 1278.417s Main  	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C 1278.417s Main  	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:758)
C 1278.417s Main  	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
C 1278.417s Main  	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
C 1278.417s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C 1278.417s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C 1278.417s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
C 1278.417s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
C 1278.417s Main  Caused by: java.util.concurrent.ExecutionException: java.lang.IndexOutOfBoundsException: Invalid index 6, size is 6
C 1278.417s Main  	at java.util.concurrent.FutureTask.report(FutureTask.java:94)
C 1278.417s Main  	at java.util.concurrent.FutureTask.get(FutureTask.java:164)
C 1278.417s Main  	at org.chromium.base.ThreadUtils.runOnUiThreadBlocking(ThreadUtils.java:77)
C 1278.417s Main  	... 18 more
C 1278.417s Main  Caused by: java.lang.IndexOutOfBoundsException: Invalid index 6, size is 6
C 1278.417s Main  	at java.util.ArrayList.throwIndexOutOfBoundsException(ArrayList.java:255)
C 1278.417s Main  	at java.util.ArrayList.get(ArrayList.java:308)
C 1278.417s Main  	at org.chromium.chrome.browser.payments.PaymentRequestTestBase$29.run(PaymentRequestTestBase.java:596)
C 1278.417s Main  	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:423)
C 1278.417s Main  	at java.util.concurrent.FutureTask.run(FutureTask.java:237)
C 1278.417s Main  	at android.os.Handler.handleCallback(Handler.java:739)
C 1278.417s Main  	at android.os.Handler.dispatchMessage(Handler.java:95)
C 1278.417s Main  	at android.os.Looper.loop(Looper.java:148)
C 1278.417s Main  	at android.app.ActivityThread.main(ActivityThread.java:5417)
C 1278.417s Main  	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
C 1278.417s Main  	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

The failure was caused index out of bounds. I can reproduce one failing test locally:
-org.chromium.chrome.browser.payments.PaymentRequestBillingAddressWithoutPhoneTest#testCantAddNewBillingAddressWithoutPhone

The suspicious CL is: https://codereview.chromium.org/2680143002. After revert the CL, the test passes. 



 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/886089f3cad28e46fa21e3d73c60fd5e87d7621f

commit 886089f3cad28e46fa21e3d73c60fd5e87d7621f
Author: parastoog <parastoog@google.com>
Date: Wed Apr 12 07:44:13 2017

Reland explanation: crrev.com/2680143002 caused chrome_public_test_apk
failing on chromium.android/Marshmallow. The problem is fixed in this
CL.

To make the payment request tests independent of the network status,
the tests set the time-out = 0,
which means that the sub-keys must never be fetched,
and the address forms will always show a textfield,
and not a dropdown for the admin areas.

In the previous CL, the time-out would start after the request.
=> For some entities (with network connection),
subkeys were already fetched, before the timeout had started.
=> A dropdown would show.

To solve this, the order was changed.
Now the time-out starts before the request.

BUG= 709491 

Review-Url: https://codereview.chromium.org/2812893002
Cr-Commit-Position: refs/heads/master@{#463945}

[modify] https://crrev.com/886089f3cad28e46fa21e3d73c60fd5e87d7621f/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/886089f3cad28e46fa21e3d73c60fd5e87d7621f/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
[modify] https://crrev.com/886089f3cad28e46fa21e3d73c60fd5e87d7621f/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/886089f3cad28e46fa21e3d73c60fd5e87d7621f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
[modify] https://crrev.com/886089f3cad28e46fa21e3d73c60fd5e87d7621f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
[modify] https://crrev.com/886089f3cad28e46fa21e3d73c60fd5e87d7621f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
[modify] https://crrev.com/886089f3cad28e46fa21e3d73c60fd5e87d7621f/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java
[modify] https://crrev.com/886089f3cad28e46fa21e3d73c60fd5e87d7621f/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java
[modify] https://crrev.com/886089f3cad28e46fa21e3d73c60fd5e87d7621f/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/886089f3cad28e46fa21e3d73c60fd5e87d7621f/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] https://crrev.com/886089f3cad28e46fa21e3d73c60fd5e87d7621f/components/payments/core/address_normalizer.cc
[modify] https://crrev.com/886089f3cad28e46fa21e3d73c60fd5e87d7621f/components/payments/core/address_normalizer.h
[modify] https://crrev.com/886089f3cad28e46fa21e3d73c60fd5e87d7621f/third_party/libaddressinput/chromium/chrome_address_validator.cc
[modify] https://crrev.com/886089f3cad28e46fa21e3d73c60fd5e87d7621f/third_party/libaddressinput/chromium/chrome_address_validator.h
[modify] https://crrev.com/886089f3cad28e46fa21e3d73c60fd5e87d7621f/third_party/libaddressinput/chromium/chrome_address_validator_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ce1b3a5c77dbe359a1592acb9bcfbadf3339bf0

commit 8ce1b3a5c77dbe359a1592acb9bcfbadf3339bf0
Author: donnd <donnd@chromium.org>
Date: Wed Apr 12 17:33:46 2017

Revert of [Reland] Use dropdown list for admin areas in pr form. (patchset #2 id:40001 of https://codereview.chromium.org/2812893002/ )

Reason for revert:
Still some lingering test failures.  See  crbug.com/710911 

Original issue's description:
> Reland explanation: crrev.com/2680143002 caused chrome_public_test_apk
> failing on chromium.android/Marshmallow. The problem is fixed in this
> CL.
>
> To make the payment request tests independent of the network status,
> the tests set the time-out = 0,
> which means that the sub-keys must never be fetched,
> and the address forms will always show a textfield,
> and not a dropdown for the admin areas.
>
> In the previous CL, the time-out would start after the request.
> => For some entities (with network connection),
> subkeys were already fetched, before the timeout had started.
> => A dropdown would show.
>
> To solve this, the order was changed.
> Now the time-out starts before the request.
>
>
> BUG= 709491 
>
> Review-Url: https://codereview.chromium.org/2812893002
> Cr-Commit-Position: refs/heads/master@{#463945}
> Committed: https://chromium.googlesource.com/chromium/src/+/886089f3cad28e46fa21e3d73c60fd5e87d7621f

TBR=mathp@chromium.org,sebsg@chromium.org,rouslan@chromium.org,dfalcantara@chromium.org,parastoog@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 709491 

Review-Url: https://codereview.chromium.org/2817733002
Cr-Commit-Position: refs/heads/master@{#464069}

[modify] https://crrev.com/8ce1b3a5c77dbe359a1592acb9bcfbadf3339bf0/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/8ce1b3a5c77dbe359a1592acb9bcfbadf3339bf0/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
[modify] https://crrev.com/8ce1b3a5c77dbe359a1592acb9bcfbadf3339bf0/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/8ce1b3a5c77dbe359a1592acb9bcfbadf3339bf0/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
[modify] https://crrev.com/8ce1b3a5c77dbe359a1592acb9bcfbadf3339bf0/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
[modify] https://crrev.com/8ce1b3a5c77dbe359a1592acb9bcfbadf3339bf0/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
[modify] https://crrev.com/8ce1b3a5c77dbe359a1592acb9bcfbadf3339bf0/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java
[modify] https://crrev.com/8ce1b3a5c77dbe359a1592acb9bcfbadf3339bf0/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java
[modify] https://crrev.com/8ce1b3a5c77dbe359a1592acb9bcfbadf3339bf0/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/8ce1b3a5c77dbe359a1592acb9bcfbadf3339bf0/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] https://crrev.com/8ce1b3a5c77dbe359a1592acb9bcfbadf3339bf0/components/payments/core/address_normalizer.cc
[modify] https://crrev.com/8ce1b3a5c77dbe359a1592acb9bcfbadf3339bf0/components/payments/core/address_normalizer.h
[modify] https://crrev.com/8ce1b3a5c77dbe359a1592acb9bcfbadf3339bf0/third_party/libaddressinput/chromium/chrome_address_validator.cc
[modify] https://crrev.com/8ce1b3a5c77dbe359a1592acb9bcfbadf3339bf0/third_party/libaddressinput/chromium/chrome_address_validator.h
[modify] https://crrev.com/8ce1b3a5c77dbe359a1592acb9bcfbadf3339bf0/third_party/libaddressinput/chromium/chrome_address_validator_unittest.cc

Components: UI>Browser>Autofill>Payments
Status: Fixed (was: Available)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment