New issue
Advanced search Search tips

Issue 709489 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Background Fetch needs to relay all the response headers

Project Member Reported by peter@chromium.org, Apr 7 2017

Issue description

Regardless whether a Background Fetch response succeeds or fails, we'll want to populate the Response objects with all headers received from the server.

As far as I can see the DownloadItem object doesn't currently expose this, so that will have to be hooked up.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87a42b7af9035be518adf40266e4a3b1463186fd

commit 87a42b7af9035be518adf40266e4a3b1463186fd
Author: peter <peter@chromium.org>
Date: Wed Apr 12 10:10:56 2017

Make the download's response headers available in the DownloadItem

Background Fetch will give this developer back to the developer, and use
it to determine whether the request was "ok". That information will also
be used to determine which Service Worker event to invoke.

The response headers will not be stored in the download database, so
requires the download to either have been started or resumed in the
current session.

BUG= 709489 

Review-Url: https://codereview.chromium.org/2809953002
Cr-Commit-Position: refs/heads/master@{#463982}

[modify] https://crrev.com/87a42b7af9035be518adf40266e4a3b1463186fd/content/browser/download/download_create_info.cc
[modify] https://crrev.com/87a42b7af9035be518adf40266e4a3b1463186fd/content/browser/download/download_create_info.h
[modify] https://crrev.com/87a42b7af9035be518adf40266e4a3b1463186fd/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/87a42b7af9035be518adf40266e4a3b1463186fd/content/browser/download/download_item_impl.h
[modify] https://crrev.com/87a42b7af9035be518adf40266e4a3b1463186fd/content/browser/download/download_item_impl_unittest.cc
[modify] https://crrev.com/87a42b7af9035be518adf40266e4a3b1463186fd/content/browser/download/download_request_core.cc
[modify] https://crrev.com/87a42b7af9035be518adf40266e4a3b1463186fd/content/public/browser/download_item.h
[modify] https://crrev.com/87a42b7af9035be518adf40266e4a3b1463186fd/content/public/test/fake_download_item.cc
[modify] https://crrev.com/87a42b7af9035be518adf40266e4a3b1463186fd/content/public/test/fake_download_item.h
[modify] https://crrev.com/87a42b7af9035be518adf40266e4a3b1463186fd/content/public/test/mock_download_item.h

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b6bb8eb5aa2c306f7ad88a746bbec775c18b103

commit 0b6bb8eb5aa2c306f7ad88a746bbec775c18b103
Author: peter <peter@chromium.org>
Date: Wed Apr 12 19:54:55 2017

Pass through the response code and headers in Background Fetch

Following this CL, Background Fetch responses will include the response
code and headers as provided by the download manager.

We don't yet support the `backgroundfetchfail` event or handle CORS, but
those can now be implemented in follow-up CLs.

BUG= 709489 

Review-Url: https://codereview.chromium.org/2814683003
Cr-Commit-Position: refs/heads/master@{#464119}

[modify] https://crrev.com/0b6bb8eb5aa2c306f7ad88a746bbec775c18b103/content/browser/background_fetch/background_fetch_data_manager.cc
[modify] https://crrev.com/0b6bb8eb5aa2c306f7ad88a746bbec775c18b103/content/browser/background_fetch/background_fetch_job_controller_unittest.cc
[modify] https://crrev.com/0b6bb8eb5aa2c306f7ad88a746bbec775c18b103/content/browser/background_fetch/background_fetch_request_info.cc
[modify] https://crrev.com/0b6bb8eb5aa2c306f7ad88a746bbec775c18b103/content/browser/background_fetch/background_fetch_request_info.h
[modify] https://crrev.com/0b6bb8eb5aa2c306f7ad88a746bbec775c18b103/content/browser/background_fetch/background_fetch_service_unittest.cc
[modify] https://crrev.com/0b6bb8eb5aa2c306f7ad88a746bbec775c18b103/content/browser/background_fetch/background_fetch_test_base.cc
[modify] https://crrev.com/0b6bb8eb5aa2c306f7ad88a746bbec775c18b103/content/browser/background_fetch/background_fetch_test_base.h

Comment 4 by peter@chromium.org, Apr 13 2017

Status: Fixed (was: Assigned)

Sign in to add a comment