[OffscreenCanvas] Promise returned by commit should be usable as placeholder sync barrier |
|||
Issue description
The implementation must guarantee that the resolution handler for the Promise returned by commit is always executed after the committed frame has been propagated to the placeholder canvas.
This should also work across thread boundaries. For example, in a worker:
context.commit().then( function () {
self.postMessage("frame committed");
} );
Then, when the message is received on the main thread, it must be guaranteed that the placeholder canvas has been update with the committed frame (or possibly a more recent frame).
Once this is fixed, all layout tests that use setTimeout as a sync barrier for commit() should be modified to use the promise instead.
,
Apr 7 2017
Tests to be fixed, see: https://codereview.chromium.org/2738773004/
,
Apr 10 2017
Note: there is also a suppression for a WebGL conformance test that will need to be updated.
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b10caf8de873181849d28ea10bea9be564875e31 commit b10caf8de873181849d28ea10bea9be564875e31 Author: skyostil <skyostil@chromium.org> Date: Wed Apr 12 14:28:10 2017 Make offscreen canvas resizing test deterministic Similarly to https://codereview.chromium.org/2738773004, two more calls to commit() should be amended with a nested timer trampoline to make sure the commit has completed before we read the results. BUG= 696001 , 709484 Review-Url: https://codereview.chromium.org/2808353005 Cr-Commit-Position: refs/heads/master@{#464017} [modify] https://crrev.com/b10caf8de873181849d28ea10bea9be564875e31/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-resize.html
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ac9902a04fadaa7e3f307cee39659578e53fe18 commit 1ac9902a04fadaa7e3f307cee39659578e53fe18 Author: zmo <zmo@chromium.org> Date: Fri Jun 09 04:56:41 2017 Update WebGL2 conformance test expectations for Win bots BUG= 491419 , 614418 ,662644, 676848 ,680754,693090,705865, 709484 TEST=GPU FYI bots TBR=kbr@chromium.org,kainino@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2927233002 Cr-Commit-Position: refs/heads/master@{#478203} [modify] https://crrev.com/1ac9902a04fadaa7e3f307cee39659578e53fe18/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Jun 29 2018
,
Aug 8
|
|||
►
Sign in to add a comment |
|||
Comment 1 by junov@chromium.org
, Apr 7 2017