New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 709483 link

Starred by 1 user
Status: Fixed
Owner:
█ joh...@chromium.org
no longer working on chrome
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocked on:
issue 693630


Sign in to add a comment

Media controls timeline metrics tests failing on Android

Project Member Reported by joh...@chromium.org, Apr 7 2017 
4 of the tests added in https://codereview.chromium.org/2779273003 fail on Android because the timeline width happens to be different for unknown reasons:
MediaControlsImplTest.TimelineMetricsDragBackAndForth
MediaControlsImplTest.TimelineMetricsClick
MediaControlsImplTest.TimelineMetricsDragFromElsewhere
MediaControlsImplTest.TimelineMetricsDragFromCurrentPosition

This caused https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/63437 to fail.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc14e3a2a3e43bacbca4b48f0ba3e66b4af9a50a

commit fc14e3a2a3e43bacbca4b48f0ba3e66b4af9a50a
Author: johnme <johnme@chromium.org>
Date: Fri Apr 07 15:04:52 2017

[Media Controls] Temporarily disable failing metrics tests on Android

The timeline width seems to differ.  https://crbug.com/709483  tracks
re-enabling these.

BUG= 709483 
TBR=mlamouri@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2802233002
Cr-Commit-Position: refs/heads/master@{#462863}

[modify] https://crrev.com/fc14e3a2a3e43bacbca4b48f0ba3e66b4af9a50a/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a262e4f88d16b143b9f754865db584e3bc9ec01c

commit a262e4f88d16b143b9f754865db584e3bc9ec01c
Author: johnme <johnme@chromium.org>
Date: Thu Jun 01 13:28:14 2017

[Media Controls] Fix and re-enable failing metrics tests on Android

BUG= 709483 

Review-Url: https://codereview.chromium.org/2919503004
Cr-Commit-Position: refs/heads/master@{#476266}

[modify] https://crrev.com/a262e4f88d16b143b9f754865db584e3bc9ec01c/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp

Comment 3 by joh...@chromium.org, Jun 2 2017

Status: Fixed (was: Started)
►

Sign in to add a comment