New issue
Advanced search Search tips

Issue 709461 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

authpolicy: Add account_id as input to AuthenticateUser

Project Member Reported by ljusten@chromium.org, Apr 7 2017

Issue description

Make sure it's backwards compatible.
Fetch account info with device TGT.

 
Labels: -Pri-3 Pri-1
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/db036b36f5d00015e765ccdcc09888ac86cbaef2

commit db036b36f5d00015e765ccdcc09888ac86cbaef2
Author: Lutz Justen <ljusten@chromium.org>
Date: Mon Apr 17 21:06:19 2017

authpolicy: Add account_id as input to AuthenticateUser

Gracefully handles missing account_id until the Chrome side sends it in.
Fetches account info using the device TGT. This is necessary to handle
the case where the user name (sAMAccountName or UPN, whatever the user
used to log in) changes on the server and we have to query it first
using the objectGUID/account_id in order to request the TGT.

BUG= chromium:709461 
TEST=Compiled, ran tests, tested on device.

Change-Id: I2060b9a0d3b5aeee78d42a69985e38437f0f15d4
Reviewed-on: https://chromium-review.googlesource.com/472786
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/db036b36f5d00015e765ccdcc09888ac86cbaef2/authpolicy/dbus_bindings/org.chromium.AuthPolicy.xml
[modify] https://crrev.com/db036b36f5d00015e765ccdcc09888ac86cbaef2/authpolicy/authpolicy.h
[modify] https://crrev.com/db036b36f5d00015e765ccdcc09888ac86cbaef2/authpolicy/stub_common.h
[modify] https://crrev.com/db036b36f5d00015e765ccdcc09888ac86cbaef2/authpolicy/samba_interface.cc
[modify] https://crrev.com/db036b36f5d00015e765ccdcc09888ac86cbaef2/authpolicy/stub_kinit_main.cc
[modify] https://crrev.com/db036b36f5d00015e765ccdcc09888ac86cbaef2/authpolicy/samba_interface.h
[modify] https://crrev.com/db036b36f5d00015e765ccdcc09888ac86cbaef2/authpolicy/stub_common.cc
[modify] https://crrev.com/db036b36f5d00015e765ccdcc09888ac86cbaef2/authpolicy/authpolicy_unittest.cc
[modify] https://crrev.com/db036b36f5d00015e765ccdcc09888ac86cbaef2/authpolicy/authpolicy.cc
[modify] https://crrev.com/db036b36f5d00015e765ccdcc09888ac86cbaef2/authpolicy/stub_net_main.cc

Status: Fixed (was: Started)

Comment 4 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Status: Verified (was: Fixed)
bulk Verify of older or not-user-facing Chromad bugs

Sign in to add a comment