New issue
Advanced search Search tips

Issue 709455 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Add empty check to ObserverList in finalize()

Project Member Reported by mvanouwe...@chromium.org, Apr 7 2017

Issue description

We could add an optional empty check to ObserverList in finalize() to push back against memory bloat and odd errors. The C++ version already has this, and it is used a lot.
 
Cc: peconn@chromium.org
If nobody has implemented this by the time I get back to England, I'll give it a go.
(sorry, for context that would essentially be after Easter)
Owner: peconn@chromium.org
Status: Assigned (was: Untriaged)
Are we ok with adding a finalizer() to ObserverList?  IIRC that adds some overhead (although maybe not much).

Comment 5 by peconn@chromium.org, Feb 12 2018

I think we discussed this and decided against it, primarily because of the overhead. It may be useful if we could find a way that the finalizer is present only in debug builds.

Sign in to add a comment