New issue
Advanced search Search tips

Issue 709454 link

Starred by 1 user
Status: Fixed
Owner:
tmartino@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

[Payments] Have a measure of completeness for addresses

Project Member Reported by ma...@chromium.org, Apr 7 2017 
Currently all addresses are considered valid in the Payments UI.

We should have a util that returns whether the address is complete, and if it isn't, returns an appropriate error message. 

This will be useful in profile_list_view_controller, which needs to know whether to open the editor.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01c3eb8fd187b96cf17164ebcf15c69da1fa660e

commit 01c3eb8fd187b96cf17164ebcf15c69da1fa660e
Author: tmartino <tmartino@chromium.org>
Date: Sat Apr 29 15:18:39 2017

[WebPayments] Show labels on incomplete profiles

Adds labels describing missing information (e.g., "Add Email Address") to shipping + contact info views. Adds validation for shipping addresses. Adds cacheing to PaymentsProfileComparator, and adds an instance to PaymentRequestState so that cached values can be used throughout the request.

BUG= 711358 , 709454 ,
TBR=mahmadi@chromium.org

Review-Url: https://codereview.chromium.org/2847503002
Cr-Commit-Position: refs/heads/master@{#468242}

[modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc
[modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/order_summary_view_controller_browsertest.cc
[modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
[modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/payment_request_browsertest_base.h
[modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h
[modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/payment_request_views_util.cc
[modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/payment_request_views_util.h
[modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/profile_list_view_controller.cc
[modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/profile_list_view_controller.h
[modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/shipping_option_view_controller_browsertest.cc
[modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/components/autofill/core/browser/autofill_profile_comparator.h
[modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/components/payments/content/payment_request_state.cc
[modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/components/payments/content/payment_request_state.h
[modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/components/payments/core/BUILD.gn
[modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/components/payments/core/payment_request_data_util.cc
[modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/components/payments/core/payment_request_data_util.h
[add] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/components/payments/core/payments_profile_comparator.cc
[add] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/components/payments/core/payments_profile_comparator.h
[add] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/components/payments/core/payments_profile_comparator_unittest.cc
[delete] https://crrev.com/b75aa7267969141e12f5ece554be20d81d39b044/components/payments/core/profile_util.cc
[delete] https://crrev.com/b75aa7267969141e12f5ece554be20d81d39b044/components/payments/core/profile_util.h
[delete] https://crrev.com/b75aa7267969141e12f5ece554be20d81d39b044/components/payments/core/profile_util_unittest.cc
[modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/ios/chrome/browser/payments/payment_request.mm

Comment 2 by tmartino@chromium.org, May 30 2017

Status: Fixed (was: Assigned)

Comment 3 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment