(looping in Infra because of the last question)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69436adf63ce69efadef1dc0082bfc2cea8b81ee

commit 69436adf63ce69efadef1dc0082bfc2cea8b81ee
Author: jkrcal <jkrcal@chromium.org>
Date: Fri Apr 07 16:58:51 2017

[WebUI] Disable 3 flaky tests on ChromiumOS dbg (timeouts)

Disabling tests:
 - CrSettingsNonExistentRouteTest.All
 - SettingsSiteSettingsPageBrowserTest.labels
 - SettingsBasicSubPageBrowserTest.SubPages

BUG=709442
TBR=tommycli@chromium.org

Review-Url: https://codereview.chromium.org/2808473002
Cr-Commit-Position: refs/heads/master@{#462895}

[modify] https://crrev.com/69436adf63ce69efadef1dc0082bfc2cea8b81ee/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/69436adf63ce69efadef1dc0082bfc2cea8b81ee/chrome/test/data/webui/settings/settings_subpage_browsertest.js
[modify] https://crrev.com/69436adf63ce69efadef1dc0082bfc2cea8b81ee/chrome/test/data/webui/settings/site_settings_page_browsertest.js

it's not clear to me that running these on debug ChromeOS is getting us anything.

we run in many other configurations, and those provide similar coverage.

+dnj@ since ChromeOS

CrSettingsNonExistentRouteTest.All and 
SettingsSiteSettingsPageBrowserTest.labels
also timeout on Windows: 
 issue 715709 

I think we should probably remove SettingsBasicSubPageBrowserTest.SubPages at this point, it has outlived its usefulness.

I will investigate the others as well.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71c5d05be29f65673640731f6c0fd442e50f6f8d

commit 71c5d05be29f65673640731f6c0fd442e50f6f8d
Author: zmin <zmin@chromium.org>
Date: Wed Apr 26 21:05:47 2017

Disable flaky tests on Windows dbg (timeouts)

Disable:
CrSettingsNonExistentRouteTest.All
SettingsSiteSettingsPageBrowserTest.labels

BUG=709442
BUG= 715709 
TBR=tommycli

Review-Url: https://codereview.chromium.org/2840293002
Cr-Commit-Position: refs/heads/master@{#467455}

[modify] https://crrev.com/71c5d05be29f65673640731f6c0fd442e50f6f8d/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/71c5d05be29f65673640731f6c0fd442e50f6f8d/chrome/test/data/webui/settings/site_settings_page_browsertest.js

 Issue 715709  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1362453f54271dc1036fc104a01cad436c3da26c

commit 1362453f54271dc1036fc104a01cad436c3da26c
Author: stevenjb <stevenjb@chromium.org>
Date: Tue May 02 17:47:31 2017

MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility

This CL:
* Removes SettingsSubpageBrowsertest which required extra complexity
  in the Settings page visibility code and only tested coarse load
  times of subpages; this testing no longer has much value.
* Eliminates SettingsPageVisibility which was creating multiple
  definitions of pageVisibility and generally confusing things.
* Defines pageVisibility in all cases (not just guest mode). This will
  allow  the use of dom-if and allows conditional pages
  (i.e. androidApps) to use the same pageVisibility system. Pages still
   default to visibile unless explicity set to 'false'.

BUG=709442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2852433003
Cr-Commit-Position: refs/heads/master@{#468702}

[modify] https://crrev.com/1362453f54271dc1036fc104a01cad436c3da26c/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/1362453f54271dc1036fc104a01cad436c3da26c/chrome/browser/resources/settings/basic_page/basic_page.js
[modify] https://crrev.com/1362453f54271dc1036fc104a01cad436c3da26c/chrome/browser/resources/settings/basic_page/compiled_resources2.gyp
[modify] https://crrev.com/1362453f54271dc1036fc104a01cad436c3da26c/chrome/browser/resources/settings/settings_main/compiled_resources2.gyp
[modify] https://crrev.com/1362453f54271dc1036fc104a01cad436c3da26c/chrome/browser/resources/settings/settings_main/settings_main.html
[modify] https://crrev.com/1362453f54271dc1036fc104a01cad436c3da26c/chrome/browser/resources/settings/settings_main/settings_main.js
[modify] https://crrev.com/1362453f54271dc1036fc104a01cad436c3da26c/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/1362453f54271dc1036fc104a01cad436c3da26c/chrome/browser/resources/settings/settings_menu/settings_menu.js
[modify] https://crrev.com/1362453f54271dc1036fc104a01cad436c3da26c/chrome/browser/resources/settings/settings_page/compiled_resources2.gyp
[delete] https://crrev.com/91779f820563506601cfc7eedbbb2c6992e33e31/chrome/browser/resources/settings/settings_page/settings_page_visibility.html
[delete] https://crrev.com/91779f820563506601cfc7eedbbb2c6992e33e31/chrome/browser/resources/settings/settings_page/settings_page_visibility.js
[modify] https://crrev.com/1362453f54271dc1036fc104a01cad436c3da26c/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/1362453f54271dc1036fc104a01cad436c3da26c/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/1362453f54271dc1036fc104a01cad436c3da26c/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/1362453f54271dc1036fc104a01cad436c3da26c/chrome/browser/resources/settings/settings_ui/settings_ui_types.js
[modify] https://crrev.com/1362453f54271dc1036fc104a01cad436c3da26c/chrome/test/data/webui/BUILD.gn
[modify] https://crrev.com/1362453f54271dc1036fc104a01cad436c3da26c/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/1362453f54271dc1036fc104a01cad436c3da26c/chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js
[modify] https://crrev.com/1362453f54271dc1036fc104a01cad436c3da26c/chrome/test/data/webui/settings/languages_page_browsertest.js
[modify] https://crrev.com/1362453f54271dc1036fc104a01cad436c3da26c/chrome/test/data/webui/settings/on_startup_browsertest.js
[modify] https://crrev.com/1362453f54271dc1036fc104a01cad436c3da26c/chrome/test/data/webui/settings/settings_main_test.js
[delete] https://crrev.com/91779f820563506601cfc7eedbbb2c6992e33e31/chrome/test/data/webui/settings/settings_subpage_browsertest.js

@stevenjb: https://codereview.chromium.org/2852433003 caused the "show home button" and "themes" options to be hidden erroneously. Can you take a look?

Filed separate bug for this, please see  issue 717663 .

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c84e3575dfa679edeeb4efe7c906d86425117e5f

commit c84e3575dfa679edeeb4efe7c906d86425117e5f
Author: stevenjb <stevenjb@chromium.org>
Date: Thu May 04 18:40:34 2017

Revert of MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility (patchset #2 id:20001 of https://codereview.chromium.org/2852433003/ )

Reason for revert:
This caused pageVisibility sub-objects to no longer be undefined which (counter intuitively) causes the sub sections to no longer be visible.

There was some discussion about various approaches to fix this here:
https://codereview.chromium.org/2861443003/

However no agreement was reached, so I am reverting this CL.

Original issue's description:
> MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility
>
> This CL:
> * Removes SettingsSubpageBrowsertest which required extra complexity
>   in the Settings page visibility code and only tested coarse load
>   times of subpages; this testing no longer has much value.
> * Eliminates SettingsPageVisibility which was creating multiple
>   definitions of pageVisibility and generally confusing things.
> * Defines pageVisibility in all cases (not just guest mode). This will
>   allow  the use of dom-if and allows conditional pages
>   (i.e. androidApps) to use the same pageVisibility system. Pages still
>    default to visibile unless explicity set to 'false'.
>
> BUG=709442
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2852433003
> Cr-Commit-Position: refs/heads/master@{#468702}
> Committed: https://chromium.googlesource.com/chromium/src/+/1362453f54271dc1036fc104a01cad436c3da26c

TBR=dpapad@chromium.org,hcarmona@chromium.org,michaelpg@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=709442

Review-Url: https://codereview.chromium.org/2866463002
Cr-Commit-Position: refs/heads/master@{#469395}

[modify] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/browser/resources/settings/basic_page/basic_page.js
[modify] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/browser/resources/settings/basic_page/compiled_resources2.gyp
[modify] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/browser/resources/settings/settings_main/compiled_resources2.gyp
[modify] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/browser/resources/settings/settings_main/settings_main.html
[modify] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/browser/resources/settings/settings_main/settings_main.js
[modify] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/browser/resources/settings/settings_menu/settings_menu.js
[modify] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/browser/resources/settings/settings_page/compiled_resources2.gyp
[add] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/browser/resources/settings/settings_page/settings_page_visibility.html
[add] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/browser/resources/settings/settings_page/settings_page_visibility.js
[modify] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/browser/resources/settings/settings_ui/settings_ui_types.js
[modify] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/test/data/webui/BUILD.gn
[modify] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js
[modify] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/test/data/webui/settings/languages_page_browsertest.js
[modify] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/test/data/webui/settings/on_startup_browsertest.js
[modify] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/test/data/webui/settings/settings_main_test.js
[add] https://crrev.com/c84e3575dfa679edeeb4efe7c906d86425117e5f/chrome/test/data/webui/settings/settings_subpage_browsertest.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d8b0d7ee334c20a8a91bd27116c1eb40a85e3e7

commit 2d8b0d7ee334c20a8a91bd27116c1eb40a85e3e7
Author: dpapad <dpapad@chromium.org>
Date: Mon May 15 22:38:52 2017

MD Settings: Eliminate SettingsSubpageBrowsertest.

 - Remove SettingsPageVisibility behavior, since only basic-page is using it.
 - Remove global var settingsHidePagesByDefaultForTest.
 - Remove settings_subpage_browsertest.js, it was used to benchmark rendering
   of specific subpages, not necessary anymore.

BUG=709442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2855253003
Cr-Commit-Position: refs/heads/master@{#471931}

[modify] https://crrev.com/2d8b0d7ee334c20a8a91bd27116c1eb40a85e3e7/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/2d8b0d7ee334c20a8a91bd27116c1eb40a85e3e7/chrome/browser/resources/settings/basic_page/basic_page.js
[modify] https://crrev.com/2d8b0d7ee334c20a8a91bd27116c1eb40a85e3e7/chrome/browser/resources/settings/basic_page/compiled_resources2.gyp
[modify] https://crrev.com/2d8b0d7ee334c20a8a91bd27116c1eb40a85e3e7/chrome/browser/resources/settings/settings_main/compiled_resources2.gyp
[modify] https://crrev.com/2d8b0d7ee334c20a8a91bd27116c1eb40a85e3e7/chrome/browser/resources/settings/settings_main/settings_main.js
[modify] https://crrev.com/2d8b0d7ee334c20a8a91bd27116c1eb40a85e3e7/chrome/browser/resources/settings/settings_menu/settings_menu.js
[modify] https://crrev.com/2d8b0d7ee334c20a8a91bd27116c1eb40a85e3e7/chrome/browser/resources/settings/settings_page/compiled_resources2.gyp
[delete] https://crrev.com/1a2e9429dd31e0929621a54e7728dcfe3a58ddab/chrome/browser/resources/settings/settings_page/settings_page_visibility.html
[delete] https://crrev.com/1a2e9429dd31e0929621a54e7728dcfe3a58ddab/chrome/browser/resources/settings/settings_page/settings_page_visibility.js
[modify] https://crrev.com/2d8b0d7ee334c20a8a91bd27116c1eb40a85e3e7/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/2d8b0d7ee334c20a8a91bd27116c1eb40a85e3e7/chrome/test/data/webui/BUILD.gn
[modify] https://crrev.com/2d8b0d7ee334c20a8a91bd27116c1eb40a85e3e7/chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js
[modify] https://crrev.com/2d8b0d7ee334c20a8a91bd27116c1eb40a85e3e7/chrome/test/data/webui/settings/on_startup_browsertest.js
[delete] https://crrev.com/1a2e9429dd31e0929621a54e7728dcfe3a58ddab/chrome/test/data/webui/settings/settings_subpage_browsertest.js