New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709436 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 712590



Sign in to add a comment

Mobile system health benchmarks should cover the case of going back to NTP

Project Member Reported by primiano@chromium.org, Apr 7 2017

Issue description

Forking form Issue 708710.
See summary in go/gnsjm for the full story.
The key reason why we didn't catch this leak in our benchmark seems to be the fact that we don't have any user story that goes back to the NTP repeatedly.

Should we add it? Is it feasible? How much work is it?
Adding relevant people.
 
Cc: ssid@chromium.org
Adding this extra system health story seems pretty no-brainer to me. Maybe ssid@ can add this extra case to his on-going EM sh stories?

From issue 708710:
for i in `seq 1 100`; do
  adb shell am start -a android.intent.action.VIEW -n com.google.android.apps.chrome/.Main
  sleep 1
  adb shell input tap 538 842 (search_box)
  sleep 1
  adb shell input text 'www.reddit.com'
  adb shell input keyevent 66
  sleep 6
  adb shell input tap 463 134 (url_bar)
  sleep 1
  adb shell input text 'news.google.com'
  adb shell input keyevent 66
  sleep 6
  adb shell input keyevent 4 (back)
  sleep 2
  adb shell input keyevent 4 (back)
  sleep 2
  adb shell input keyevent 3 (home)
  sleep 2
done
Labels: Performance-Browser
Labels: Performance-Memory
Labels: sr-pm-6
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c96514f650b4db1f6abebf0d6b307d65bca3e5b

commit 2c96514f650b4db1f6abebf0d6b307d65bca3e5b
Author: ssid <ssid@chromium.org>
Date: Mon Apr 17 20:42:42 2017

Add System health stories for Emerging market

This CL adds system health stories which are important for emerging
market.

BUG=708300, 709436 

Review-Url: https://codereview.chromium.org/2787103003
Cr-Commit-Position: refs/heads/master@{#465012}

[modify] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/data/system_health_mobile.json
[add] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/data/system_health_mobile_053.wpr.sha1
[add] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/data/system_health_mobile_055.wpr.sha1
[add] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/data/system_health_mobile_056.wpr.sha1
[add] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/data/system_health_mobile_058.wpr.sha1
[add] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/data/system_health_mobile_059.wpr.sha1
[add] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/data/system_health_mobile_060.wpr.sha1
[add] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/data/system_health_mobile_061.wpr.sha1
[modify] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/system_health/browsing_stories.py
[modify] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/system_health/loading_stories.py
[modify] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/system_health/searching_stories.py
[modify] https://crrev.com/2c96514f650b4db1f6abebf0d6b307d65bca3e5b/tools/perf/page_sets/system_health/story_tags.py

Owner: ssid@chromium.org
Status: Assigned (was: Available)
Can we close this, then?

Comment 7 by ssid@chromium.org, Apr 20 2017

Status: Fixed (was: Assigned)
Yes.
(But it is currently disabled because of  issue 712590 )
Blockedon: 712590

Sign in to add a comment