New issue
Advanced search Search tips

Issue 709426 link

Starred by 1 user
Status: Fixed
Owner:
dgozman@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

inspector/screen-orientation-override.htm doesn't work on portrait setups

Project Member Reported by jochen@chromium.org, Apr 7 2017 
if you have your monitor in portrait mode, the screen-orientation-override test fails.

It would be nice if it would work independent of the actual screen setup

Diff is

@@ -2,7 +2,7 @@
 CONSOLE MESSAGE: line 25: angle: 180; type: portrait-secondary
 CONSOLE MESSAGE: line 25: angle: 90; type: landscape-primary
 CONSOLE MESSAGE: line 25: angle: 270; type: landscape-secondary
-CONSOLE MESSAGE: line 25: angle: 0; type: landscape-primary
+CONSOLE MESSAGE: line 25: angle: 270; type: portrait-primary
 
 Running: initial
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abc172e25ae45eae70f4891d12e6c76445857686

commit abc172e25ae45eae70f4891d12e6c76445857686
Author: dgozman <dgozman@chromium.org>
Date: Fri Apr 07 23:21:06 2017

[DevTools] Make screen-orientation-override agnostic to real screen orientation

The test is already pretty robust, but it mistakenly console.logs the
original orientation. Disabling logging solves the problem.

BUG= 709426 

Review-Url: https://codereview.chromium.org/2803233003
Cr-Commit-Position: refs/heads/master@{#463043}

[modify] https://crrev.com/abc172e25ae45eae70f4891d12e6c76445857686/third_party/WebKit/LayoutTests/inspector/screen-orientation-override-expected.txt
[modify] https://crrev.com/abc172e25ae45eae70f4891d12e6c76445857686/third_party/WebKit/LayoutTests/inspector/screen-orientation-override.html

Comment 2 by dgozman@chromium.org, Apr 7 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment