Issue metadata
Sign in to add a comment
|
Get back -Wshorten-64-to-32 warning in GN |
||||||||||||||||||||
Issue descriptionSee: https://cs.chromium.org/chromium/src/v8/gypfiles/standalone.gypi?type=cs&q=%22-Wshorten-64-to-32%22+package:%5Echromium$&l=798 V8 had it in gyp and should have it in GN again.
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/64173571eb3852eff63ff010dccd94d603adb278 commit 64173571eb3852eff63ff010dccd94d603adb278 Author: Michael Achenbach <machenbach@chromium.org> Date: Tue Apr 11 09:48:21 2017 [build] Fix erroneously removed warning flag. Bug: chromium:709420 TBR=marja@chromium.org Change-Id: I71cf02137bcc7d8e163162c6dc1be6b906422281 Reviewed-on: https://chromium-review.googlesource.com/474747 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#44552} [modify] https://crrev.com/64173571eb3852eff63ff010dccd94d603adb278/BUILD.gn
,
Apr 11 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by machenb...@chromium.org
, Apr 11 2017