New issue
Advanced search Search tips

Issue 709413 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
aga...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

consider pulling reviewer status information from gerrit

Project Member Reported by jochen@chromium.org, Apr 7 2017 
git cl owners currently displays comments found in OWNERS files (and in an configurable additional file, for chromium build/OWNERS.status)

We could consider pulling the status from gerrit instead / in addition

Comment 1 by aga...@chromium.org, Apr 12 2017

Status: WontFix (was: Untriaged)
I'm confused, what are you proposing? Gerrit has no idea who the OWNERS are, that information is canonically stored in the repo.

There have been discussions about adding support to gerrit (via a plugin) to detect that the current set of reviewers can't provide all necessary OWNERS lgtms.

Are you proposing that OWNERS be managed as gerrit groups, instead of text files? That's something you'd have to take up with the Chromium eng elders, not the code review team.

Comment 2 by jochen@chromium.org, Apr 12 2017

Status: Untriaged (was: WontFix)
no, I'm proposing to pull the "status" that everybody can configure for themselves in gerrit and display it when suggesting owners, so you could get information about who is out of office

Comment 3 by michae...@chromium.org, Feb 10 2018

Components: Infra>SDK
This would be really cool. Does gerrit's api provide this info already?

Comment 4 by aga...@chromium.org, Feb 12 2018

Status: Available (was: Untriaged)
Easy! https://gerrit-review.googlesource.com/Documentation/rest-api-accounts.html#get-account-status

Just takes a bunch of calls, since there can easily be 10+ people in the OWNERS chain.
►

Sign in to add a comment