New issue
Advanced search Search tips

Issue 709394 link

Starred by 1 user
Status: Fixed
Owner:
maxmorin@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"RendererAudioOutputStreamFactoryIntegrationTest.StreamIntegrationTest" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 7 2017 
"RendererAudioOutputStreamFactoryIntegrationTest.StreamIntegrationTest" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUAsSBUZsYWtlIkVSZW5kZXJlckF1ZGlvT3V0cHV0U3RyZWFtRmFjdG9yeUludGVncmF0aW9uVGVzdC5TdHJlYW1JbnRlZ3JhdGlvblRlc3QM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by foolip@chromium.org, Apr 7 2017

Owner: maxmorin@chromium.org
Status: Assigned (was: Untriaged)
The flaky test was added (relanded) in https://chromium.googlesource.com/chromium/src/+/2781f5ff2c35d8d4d51205592a72f2ec28968ace, assigning to author.

I will disable the flaky test on Win for now.

Comment 2 by foolip@chromium.org, Apr 7 2017 

Disabling CL going through CQ now: https://codereview.chromium.org/2804953006

Comment 3 by maxmorin@chromium.org, Apr 7 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec5dca5c2345b87104ef47fee11ac9fce6b1f0cc

commit ec5dca5c2345b87104ef47fee11ac9fce6b1f0cc
Author: foolip <foolip@chromium.org>
Date: Fri Apr 07 10:44:00 2017

Disable RendererAudioOutputStreamFactoryIntegrationTest.StreamIntegrationTest on Win

BUG= 709394 
TBR=maxmorin@chromium.org

Review-Url: https://codereview.chromium.org/2804953006
Cr-Commit-Position: refs/heads/master@{#462832}

[modify] https://crrev.com/ec5dca5c2345b87104ef47fee11ac9fce6b1f0cc/content/browser/renderer_host/media/renderer_audio_output_stream_factory_context_impl_unittest.cc

Comment 5 by jkrcal@chromium.org, Apr 7 2017

Labels: -Sheriff-Chromium

Comment 6 by maxmorin@chromium.org, Apr 10 2017 

Summary of failures (to make bug searchable and to preserve it after the logs are gone):

#1: Looks like -1 was used as a handle. Also looks like the stack trace is a bit broken.
[ RUN      ] RendererAudioOutputStreamFactoryIntegrationTest.StreamIntegrationTest

GMOCK WARNING:
Uninteresting mock function call - taking default action specified at:
e:\b\c\b\win\src\content\browser\renderer_host\media\renderer_audio_output_stream_factory_context_impl_unittest.cc(113):
    Function call: HasAudioOutputDevices()
          Returns: true
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details.
[4864:3796:0406/130109.559:34605904:FATAL:waitable_event_win.cc(62)] Check failed: ((((DWORD )0x00000000L) ) + 0 ) == result (0 vs. 4294967295)WaitForSingleObject failed
Backtrace:
	base::debug::StackTrace::StackTrace [0x0000000141A0C285+69]
	base::debug::StackTrace::StackTrace [0x0000000141A34DE3+19]
	logging::LogMessage::~LogMessage [0x000000014199FCFA+74]
	base::WaitableEvent::Wait [0x00000001419B2383+163]
	testing::internal::TypedExpectation<bool __cdecl(content::DownloadItemImpl * __ptr64,base::Callback<void __cdecl(bool),1,1> const & __ptr64)>::ShouldHandleArguments [0x000000013FAC0C7C+2908]
	testing::internal::TypedExpectation<bool __cdecl(content::DownloadItemImpl * __ptr64,base::Callback<void __cdecl(bool),1,1> const & __ptr64)>::ShouldHandleArguments [0x000000013FAC0DBD+3229]
	content::RendererAudioOutputStreamFactoryIntegrationTest_StreamIntegrationTest_Test::TestBody [0x000000013FABB408+2088]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::TestCase,void> [0x00000001418665ED+61]
	testing::Test::Run [0x0000000141871CDA+122]
	testing::TestInfo::Run [0x0000000141871ED1+161]
	testing::TestCase::Run [0x0000000141871DB5+165]
	testing::internal::UnitTestImpl::RunAllTests [0x0000000141872282+562]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x000000014186668D+61]
	testing::UnitTest::Run [0x0000000141872019+217]
	base::TestSuite::Run [0x00000001412424D9+137]
	base::LaunchUnitTests [0x000000014123F952+1010]
	base::LaunchUnitTests [0x000000014123F5C7+103]
	main [0x000000013FE30BE5+133]
	__scrt_common_main_seh [0x00000001431DCAE9+285] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
	BaseThreadInitThunk [0x00000000779159ED+13]
	RtlUserThreadStart [0x0000000077A4C541+33]

#2:
[ RUN      ] RendererAudioOutputStreamFactoryIntegrationTest.StreamIntegrationTest

GMOCK WARNING:
Uninteresting mock function call - taking default action specified at:
e:\b\c\b\win\src\content\browser\renderer_host\media\renderer_audio_output_stream_factory_context_impl_unittest.cc(113):
    Function call: HasAudioOutputDevices()
          Returns: true
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details.
[5644:536:0405/110302.418:1297975:FATAL:scoped_handle.cc(116)] Check failed: false.
Backtrace:
	base::debug::StackTrace::StackTrace [0x0000000141CA4CD5+69]
	base::debug::StackTrace::StackTrace [0x0000000141CCC193+19]
	logging::LogMessage::~LogMessage [0x0000000141C373EA+74]
	std::unordered_map<void * __ptr64,`anonymous namespace'::Info,A0x9642f3e1::HandleHash,std::equal_to<void * __ptr64>,std::allocator<std::pair<void * __ptr64 const,`anonymous namespace'::Info> > >::unordered_map<void * __ptr64,`anonymous namespace'::Info,A0 [0x0000000141C93F4F+287]
	base::WaitableEvent::~WaitableEvent [0x0000000141CB0765+53]
	base::internal::Invoker<base::internal::BindState<void (__cdecl content::`anonymous namespace'::TestIPCClient::*)(mojo::ScopedHandleBase<mojo::SharedBufferHandle>,mojo::ScopedHandleBase<mojo::Handle>) __ptr64,base::internal::UnretainedWrapper<content::`an [0x000000013FD83068+2872]
	base::internal::Invoker<base::internal::BindState<void (__cdecl content::`anonymous namespace'::TestIPCClient::*)(mojo::ScopedHandleBase<mojo::SharedBufferHandle>,mojo::ScopedHandleBase<mojo::Handle>) __ptr64,base::internal::UnretainedWrapper<content::`an [0x000000013FD831C3+3219]
	content::RendererAudioOutputStreamFactoryIntegrationTest_StreamIntegrationTest_Test::TestBody [0x000000013FD7DFE8+2088]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::TestCase,void> [0x0000000141AFDF7D+61]
	testing::Test::Run [0x0000000141B096BA+122]
	testing::TestInfo::Run [0x0000000141B098B1+161]
	testing::TestCase::Run [0x0000000141B09795+165]
	testing::internal::UnitTestImpl::RunAllTests [0x0000000141B09C62+562]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x0000000141AFE01D+61]
	testing::UnitTest::Run [0x0000000141B099F9+217]
	base::TestSuite::Run [0x00000001414DD8E9+137]
	base::LaunchUnitTests [0x00000001414DAD52+1010]
	base::LaunchUnitTests [0x00000001414DA9C7+103]
	main [0x00000001400F0335+133]
	__scrt_common_main_seh [0x0000000143472B69+285] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
	BaseThreadInitThunk [0x00000000776359CD+13]
	RtlUserThreadStart [0x000000007786B891+33]



#3: Looks like a less broken version of #1.
[ RUN      ] RendererAudioOutputStreamFactoryIntegrationTest.StreamIntegrationTest

GMOCK WARNING:
Uninteresting mock function call - taking default action specified at:
e:\b\c\b\win\src\content\browser\renderer_host\media\renderer_audio_output_stream_factory_context_impl_unittest.cc(113):
    Function call: HasAudioOutputDevices()
          Returns: true
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details.
[5644:536:0405/110302.418:1297975:FATAL:scoped_handle.cc(116)] Check failed: false.
Backtrace:
	base::debug::StackTrace::StackTrace [0x0000000141CA4CD5+69]
	base::debug::StackTrace::StackTrace [0x0000000141CCC193+19]
	logging::LogMessage::~LogMessage [0x0000000141C373EA+74]
	std::unordered_map<void * __ptr64,`anonymous namespace'::Info,A0x9642f3e1::HandleHash,std::equal_to<void * __ptr64>,std::allocator<std::pair<void * __ptr64 const,`anonymous namespace'::Info> > >::unordered_map<void * __ptr64,`anonymous namespace'::Info,A0 [0x0000000141C93F4F+287]
	base::WaitableEvent::~WaitableEvent [0x0000000141CB0765+53]
	base::internal::Invoker<base::internal::BindState<void (__cdecl content::`anonymous namespace'::TestIPCClient::*)(mojo::ScopedHandleBase<mojo::SharedBufferHandle>,mojo::ScopedHandleBase<mojo::Handle>) __ptr64,base::internal::UnretainedWrapper<content::`an [0x000000013FD83068+2872]
	base::internal::Invoker<base::internal::BindState<void (__cdecl content::`anonymous namespace'::TestIPCClient::*)(mojo::ScopedHandleBase<mojo::SharedBufferHandle>,mojo::ScopedHandleBase<mojo::Handle>) __ptr64,base::internal::UnretainedWrapper<content::`an [0x000000013FD831C3+3219]
	content::RendererAudioOutputStreamFactoryIntegrationTest_StreamIntegrationTest_Test::TestBody [0x000000013FD7DFE8+2088]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::TestCase,void> [0x0000000141AFDF7D+61]
	testing::Test::Run [0x0000000141B096BA+122]
	testing::TestInfo::Run [0x0000000141B098B1+161]
	testing::TestCase::Run [0x0000000141B09795+165]
	testing::internal::UnitTestImpl::RunAllTests [0x0000000141B09C62+562]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x0000000141AFE01D+61]
	testing::UnitTest::Run [0x0000000141B099F9+217]
	base::TestSuite::Run [0x00000001414DD8E9+137]
	base::LaunchUnitTests [0x00000001414DAD52+1010]
	base::LaunchUnitTests [0x00000001414DA9C7+103]
	main [0x00000001400F0335+133]
	__scrt_common_main_seh [0x0000000143472B69+285] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
	BaseThreadInitThunk [0x00000000776359CD+13]
	RtlUserThreadStart [0x000000007786B891+33]

#4: Looks like a broken version of #2.
[ RUN      ] RendererAudioOutputStreamFactoryIntegrationTest.StreamIntegrationTest

GMOCK WARNING:
Uninteresting mock function call - taking default action specified at:
e:\b\c\b\win\src\content\browser\renderer_host\media\renderer_audio_output_stream_factory_context_impl_unittest.cc(113):
    Function call: HasAudioOutputDevices()
          Returns: true
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details.
[4628:1708:0406/144014.638:1305463:FATAL:scoped_handle.cc(116)] Check failed: false.
Backtrace:
	base::debug::StackTrace::StackTrace [0x0000000141C8A6E5+69]
	base::debug::StackTrace::StackTrace [0x0000000141CB2773+19]
	logging::LogMessage::~LogMessage [0x0000000141C1E56A+74]
	std::unordered_map<void * __ptr64,`anonymous namespace'::Info,A0x815015de::HandleHash,std::equal_to<void * __ptr64>,std::allocator<std::pair<void * __ptr64 const,`anonymous namespace'::Info> > >::unordered_map<void * __ptr64,`anonymous namespace'::Info,A0 [0x0000000141C79D1F+287]
	base::WaitableEvent::~WaitableEvent [0x0000000141C30AC5+53]
	testing::internal::TypedExpectation<void __cdecl(__int64,__int64,std::vector<content::DownloadItem::ReceivedSlice,std::allocator<content::DownloadItem::ReceivedSlice> > const & __ptr64)>::ShouldHandleArguments [0x000000013FD430F8+2920]
	testing::internal::TypedExpectation<void __cdecl(__int64,__int64,std::vector<content::DownloadItem::ReceivedSlice,std::allocator<content::DownloadItem::ReceivedSlice> > const & __ptr64)>::ShouldHandleArguments [0x000000013FD43253+3267]
	content::RendererAudioOutputStreamFactoryIntegrationTest_StreamIntegrationTest_Test::TestBody [0x000000013FD3D878+2088]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::TestCase,void> [0x0000000141AE543D+61]
	testing::Test::Run [0x0000000141AF0C4A+122]
	testing::TestInfo::Run [0x0000000141AF0E41+161]
	testing::TestCase::Run [0x0000000141AF0D25+165]
	testing::internal::UnitTestImpl::RunAllTests [0x0000000141AF11F2+562]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x0000000141AE54DD+61]
	testing::UnitTest::Run [0x0000000141AF0F89+217]
	base::TestSuite::Run [0x00000001414C1A79+137]
	base::LaunchUnitTests [0x00000001414BEE92+1010]
	base::LaunchUnitTests [0x00000001414BEB07+103]
	main [0x00000001400AFD35+133]
	__scrt_common_main_seh [0x00000001434587C9+285] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
	BaseThreadInitThunk [0x0000000076C859BD+13]
	RtlUserThreadStart [0x0000000076DBA2E1+33]

#5: There was also some timeouts.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4bcb119316cfccf5c1ddcebe3b6d65a7fec09e4

commit d4bcb119316cfccf5c1ddcebe3b6d65a7fec09e4
Author: maxmorin <maxmorin@chromium.org>
Date: Thu Apr 13 11:43:13 2017

Fix double close in MojoAudioOutputStream.

Currently, the sync socket in MojoAudioOutputStream is closed by both
Mojo and the SyncSocket destructor. This causes problems if a handle
happens to be reused.

BUG= 709394 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2809673002
Cr-Commit-Position: refs/heads/master@{#464374}

[modify] https://crrev.com/d4bcb119316cfccf5c1ddcebe3b6d65a7fec09e4/base/sync_socket.h
[modify] https://crrev.com/d4bcb119316cfccf5c1ddcebe3b6d65a7fec09e4/base/sync_socket_nacl.cc
[modify] https://crrev.com/d4bcb119316cfccf5c1ddcebe3b6d65a7fec09e4/base/sync_socket_posix.cc
[modify] https://crrev.com/d4bcb119316cfccf5c1ddcebe3b6d65a7fec09e4/base/sync_socket_win.cc
[modify] https://crrev.com/d4bcb119316cfccf5c1ddcebe3b6d65a7fec09e4/content/browser/renderer_host/media/audio_output_delegate_impl.cc
[modify] https://crrev.com/d4bcb119316cfccf5c1ddcebe3b6d65a7fec09e4/content/browser/renderer_host/media/audio_output_delegate_impl_unittest.cc
[modify] https://crrev.com/d4bcb119316cfccf5c1ddcebe3b6d65a7fec09e4/content/browser/renderer_host/media/audio_renderer_host.cc
[modify] https://crrev.com/d4bcb119316cfccf5c1ddcebe3b6d65a7fec09e4/content/browser/renderer_host/media/audio_renderer_host.h
[modify] https://crrev.com/d4bcb119316cfccf5c1ddcebe3b6d65a7fec09e4/content/browser/renderer_host/media/audio_sync_reader.cc
[modify] https://crrev.com/d4bcb119316cfccf5c1ddcebe3b6d65a7fec09e4/content/browser/renderer_host/media/audio_sync_reader.h
[modify] https://crrev.com/d4bcb119316cfccf5c1ddcebe3b6d65a7fec09e4/content/browser/renderer_host/media/render_frame_audio_output_stream_factory_unittest.cc
[modify] https://crrev.com/d4bcb119316cfccf5c1ddcebe3b6d65a7fec09e4/media/audio/audio_output_delegate.h
[modify] https://crrev.com/d4bcb119316cfccf5c1ddcebe3b6d65a7fec09e4/media/mojo/services/mojo_audio_output_stream.cc
[modify] https://crrev.com/d4bcb119316cfccf5c1ddcebe3b6d65a7fec09e4/media/mojo/services/mojo_audio_output_stream.h
[modify] https://crrev.com/d4bcb119316cfccf5c1ddcebe3b6d65a7fec09e4/media/mojo/services/mojo_audio_output_stream_unittest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca39907dfb4412fa42ab98d42eb3419b97c83211

commit ca39907dfb4412fa42ab98d42eb3419b97c83211
Author: maxmorin <maxmorin@chromium.org>
Date: Thu Apr 20 07:46:57 2017

Revert of Disable RendererAudioOutputStreamFactoryIntegrationTest.StreamIntegrationTest on Win (patchset #1 id:1 of https://codereview.chromium.org/2804953006/ )

Reason for revert:
Fixed issue with code: https://codereview.chromium.org/2809673002

Original issue's description:
> Disable RendererAudioOutputStreamFactoryIntegrationTest.StreamIntegrationTest on Win
>
> BUG= 709394 
> TBR=maxmorin@chromium.org
>
> Review-Url: https://codereview.chromium.org/2804953006
> Cr-Commit-Position: refs/heads/master@{#462832}
> Committed: https://chromium.googlesource.com/chromium/src/+/ec5dca5c2345b87104ef47fee11ac9fce6b1f0cc

TBR=foolip@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 709394 

Review-Url: https://codereview.chromium.org/2828203002
Cr-Commit-Position: refs/heads/master@{#465939}

[modify] https://crrev.com/ca39907dfb4412fa42ab98d42eb3419b97c83211/content/browser/renderer_host/media/renderer_audio_output_stream_factory_context_impl_unittest.cc

Comment 9 by maxmorin@chromium.org, Apr 24 2017

Status: Fixed (was: Started)
►

Sign in to add a comment