New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709372 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

'You're now signed in to Chrome' overlay gets close after hitting Enter key, even if focus is on Checkbox.

Reported by db...@etouch.net, Apr 7 2017

Issue description

Chrome Version: 59.0.3065.0 Revision 1d73b1aebe5f3a978a5a87c7502689b49ba1b134-refs/heads/master@{#462712}
OS:Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (Ubuntu 14.04 LTS)

What steps will reproduce the problem?
(1) Launch chrome, click on Profile icon and click on Sign into Chrome button.
(2) Enter valid email id and password, hitt Enter key(You're now signed in to Chrome overlay opened)
(3) Press Tab key upto focus reaches to Checkbox, hitt Enter key and observe.

Actual: You're now signed in to Chrome overlay gets close after hitting Enter key even if focus on Checkbox.

Expected: You're now signed in to Chrome overlay should not close.

This is a non-regression issue, seen from 'M-59' as Checkbox is added into 59.0.3065.0  build.
 
Actual_Signin.mp4
988 KB View Download
Status: Untriaged (was: Unconfirmed)
Untriaged it so that it gets addressed.

Comment 2 by ew...@chromium.org, Apr 12 2017

Cc: ew...@chromium.org msarda@chromium.org
Labels: ReleaseBlock-Stable
Owner: dbeam@chromium.org
Status: Assigned (was: Untriaged)
Re-assigning to Dan. This needs to be fixed before 59 rolls out to stable, since hitting enter when the keyboard focus is on the checkbox actually clicks "OK, GOT IT" and signs the user in.

Comment 3 by ew...@chromium.org, Apr 12 2017

Labels: -Pri-2 Pri-1

Comment 4 by dbeam@chromium.org, Apr 12 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ea6afa33f38f87ee84a894fb667b29784b031fe

commit 4ea6afa33f38f87ee84a894fb667b29784b031fe
Author: dbeam <dbeam@chromium.org>
Date: Wed Apr 12 19:31:17 2017

Sync confirmation: Enter on paper-checkbox shouldn't confirm dialog

R=tommycli@chromium.org
BUG= 709372 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2817743002
Cr-Commit-Position: refs/heads/master@{#464109}

[modify] https://crrev.com/4ea6afa33f38f87ee84a894fb667b29784b031fe/chrome/browser/resources/signin/sync_confirmation/sync_confirmation.js

Comment 6 by dbeam@chromium.org, Apr 12 2017

Status: Fixed (was: Started)
Labels: TE-Verified-59.0.3071.9 TE-Verified-M59
Tested the issue on Mac 10.12.4,Windows 7 & Ubuntu 14.04 using chrome version# 59.0.3071.9.
Observed that "You're now signed in to Chrome' overlay is not getting closed after hitting enter key on check box.
Since it is working as expected, adding TE-Verified labels.
Please find the attached screen cast for the same.
Thanks!!
709372.mp4
843 KB View Download

Sign in to add a comment