New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709359 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Incorrect focus position for 'Show Home Button' is seen after pressing Tab.

Reported by aiman.an...@etouch.net, Apr 7 2017

Issue description

Chrome Version: 59.0.3065.0 (Official Build) (64-bit) (cohort: Stable)1d73b1aebe5f3a978a5a87c7502689b49ba1b134-refs/heads/master@{#462712}(32/64 Bit).

OS: Windows(7,8,8.1,10),Mac(10.11.6, 10.12.1, 10.12) and Linux(14.04 LTS).

Steps to reproduce:
1.Launch chrome, go to chrome://settings/appearance, click on 'Show Home Button' text.
2.Press tab and observe. 

Actual Result: Incorrect focus position is seen after pressing tab.
Expected Result: Incorrect focus position should not be seen(Focus should be seen at 'Show Home Button') after pressing tab.

This is regression issue broken in 'M 59' and will soon update the bisect info:

Manual Bisect Info: 
Good Build 59.0.3063.0
Bad Build 59.0.3064.0


 
Actual Result.mp4
1.3 MB View Download
Expected Result.mp4
1.1 MB View Download
Labels: hasbisect-per-revision Proj-MaterialDesign-WebUI
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 59.0.3063.0 (Revision: 461928).
Bad build : 59.0.3064.0 (Revision: 462305).

You are probably looking for a change made after 462303 (known good), but no later than 462304 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/c198feadcc54ea92134df2dc3a5f4f390fcd9493..9b3c62205a0b13f99c59792b834f485b825e2cb8


@dpapad: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Thank You.
Cc: dbeam@chromium.org
So, I think I found the issue. Now that the outer container div has a tabindex of -1, it is focusable. When the user clicks on "Show home button" div, the focus travels to the outer container, because the "Show home button" div itself is not focusable.

A possible fix is at https://codereview.chromium.org/2798223006, but we would need to deploy this to all our clickable div "buttons". I am not sure if this is worth it, or whether we should simply revert the original CL (and mark the original bug as WAI,  crbug.com/707106 ).
I uploaded a better approach in the same CL mentioned above. Removing the tabindex attribute from the container after it is blurred seems to address this regression, without creating any other unwanted sideeffects.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a2e5144ab506f18ae56a2bbe4eb23f43ddd5dcd

commit 3a2e5144ab506f18ae56a2bbe4eb23f43ddd5dcd
Author: dpapad <dpapad@chromium.org>
Date: Sat Apr 08 03:07:54 2017

MD Settings: Remove tabindex from container after it is blurred.

Clicking on non-focusable elements (for example the "Show home button" row) would
transfer the focus to the container accidentally, now that it has a tabindex. Removing
the tabindex from the container as soon as the container is blurred addresses the problem.

BUG= 709359 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2798223006
Cr-Commit-Position: refs/heads/master@{#463118}

[modify] https://crrev.com/3a2e5144ab506f18ae56a2bbe4eb23f43ddd5dcd/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/3a2e5144ab506f18ae56a2bbe4eb23f43ddd5dcd/chrome/browser/resources/settings/settings_ui/settings_ui.js

Comment 6 by dbeam@chromium.org, Apr 10 2017

Status: Fixed (was: Assigned)
Components: Blink>HTML>Focus
Components: -Blink>Focus

Sign in to add a comment