New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 709350 link

Starred by 2 users
Status: Fixed
Owner:
dgozman@chromium.org
Closed: Apr 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Customize and control Devtools' menu closes after clicking on 'More tools'

Reported by sans...@etouch.net, Apr 7 2017 
Chrome Version : 59.0.3065.0 (Official Build) 1d73b1aebe5f3a978a5a87c7502689b49ba1b134-refs/heads/master@{#462712} 32/64 bit
OS : Windows (7,8,10), Linux(14.04 LTS), Mac OS X(10.11.6, 10.12.1)

Steps:
1. Launch Chrome,open devtools on NTP and click on 'Customize and control Devtools' (three dot icon)
2. Click on 'More tools' and observe

Actual: 'Customize and control Devtools' (three dot menu) menu closes after clicking on 'More tools'

Expected: 'Customize and control Devtools' (three dot menu) menu should not close after clicking on 'More tools'

This is regression issuevbroken in ‘M 59’ and will soon update the bisect info

Good build: 59.0.3056.0
Bad build: 59.0.3057.0
Actual_video.mp4
474 KB View Download
Expected_video.mp4
352 KB View Download

Comment 1 by rbasuvula@chromium.org, Apr 7 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: dgozman@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:59.0.3056.0 (Revision:460603).
Bad build:59.0.3057.0 (Revision:460966).

You are probably looking for a change made after 460910 (known good), but no later than 460911 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/0c64e3912571118d628f513ccc3a7eb6224099d8..f05869713aa6363110a45d45a03ebb0c946744d8

From the CL above, assigning the issue to the concern owner

@dgozman: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:  https://codereview.chromium.org/2790613003
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #59.0.3065.0
Adding Release Block-Stable for this issue.Please remove if not the case.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d09b0aeddb1407f22981575e6b4fd8473830c5d

commit 9d09b0aeddb1407f22981575e6b4fd8473830c5d
Author: dgozman <dgozman@chromium.org>
Date: Fri Apr 07 22:59:34 2017

[DevTools] Listen to mousedown in SoftContextMenu once

We used to handle that through GlassPane, which has problems
with multiple layers of SoftContextMenus. Now we have a single
listener on bubble, and cancel all menus at that point.

BUG= 709350 

Review-Url: https://codereview.chromium.org/2801373002
Cr-Commit-Position: refs/heads/master@{#463032}

[modify] https://crrev.com/9d09b0aeddb1407f22981575e6b4fd8473830c5d/third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js
[modify] https://crrev.com/9d09b0aeddb1407f22981575e6b4fd8473830c5d/third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js

Comment 3 by dgozman@chromium.org, Apr 7 2017

Status: Fixed (was: Assigned)

Comment 4 by kkaluri@chromium.org, Apr 11 2017

Labels: TE-Verified-M59 TE-Verified-59.0.3067.0 TE-Verified-59.0.3067.6
Verified this issue on Windows 10 with chrome(#59.0.3067.6)  and also ubuntu 14.04, mac 10.12.4 with chrome (#59.0.3067.0)
Observed fix is working as expected.Hence adding TE-verified labels

Adding screen-cast for reference.

Thank You...
Issue 709350.mp4
873 KB View Download
►

Sign in to add a comment