Issue metadata
Sign in to add a comment
|
Regression : default focus is missing in extension install prompt
Reported by
avsha...@etouch.net,
Apr 7 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version : 59.0.3065.0 (Official Build) 1d73b1aebe5f3a978a5a87c7502689b49ba1b134-refs/heads/master@{#462712} 32/64 bit OS : Windows (7,8,10), Linux(14.04 LTS) Test URL : https://chrome.google.com/webstore/search/pdf%20viewer?utm_source=chrome-ntp-icon What steps will reproduce the problem? 1. Launch chrome and navigate to above test URL. 2. Click on 'ADD TO CHROME' button seen next to the first extension name, immediately observe the 'Add extension' button and default blue focus ring in install prompt. Actual : 1. In install prompt, 'Add extension' button enables after a slight delay. 2. Default blue focus ring is missing from 'Cancel' button. Expected : In install prompt, 'Add extension' button should not take time to get enabled and default blue focus ring should be present on 'Cancel' button. This is a regression issue broken in ‘M-59’, below is the Manual Regression range and will soon update other info. Good build : 59.0.3063.0 Bad build : 59.0.3064.0 Note : Above issue is only seen on Windows(7,8,10) & Linux(14.04 LTS) OS and the same is not reproducible on Mac(10.11.6, 10.12.1) OS since the UI is different.
,
Apr 7 2017
Issue 709393 has been merged into this issue.
,
Apr 7 2017
The delay in enabling the "Add extension" button is working as intended. However, the lost focus of the cancel button is not. I will work on getting a fix out for that.
,
Apr 11 2017
That is not a HTML <dialog> but Chrome UI.
,
Apr 11 2017
Updating description to reflect WAI vs regression.
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db4ba3ee847c91f8d5120757389c96036b01c37d commit db4ba3ee847c91f8d5120757389c96036b01c37d Author: ackermanb <ackermanb@chromium.org> Date: Fri May 26 22:33:03 2017 Ensure default dialog button focus remains after a dialog update. BUG= 709346 Review-Url: https://codereview.chromium.org/2807653002 Cr-Commit-Position: refs/heads/master@{#475165} [modify] https://crrev.com/db4ba3ee847c91f8d5120757389c96036b01c37d/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc [modify] https://crrev.com/db4ba3ee847c91f8d5120757389c96036b01c37d/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc [modify] https://crrev.com/db4ba3ee847c91f8d5120757389c96036b01c37d/ui/views/window/dialog_client_view.cc [modify] https://crrev.com/db4ba3ee847c91f8d5120757389c96036b01c37d/ui/views/window/dialog_client_view_unittest.cc
,
Jun 21 2017
This should be fixed with the above patch.
,
Jun 21 2017
M59 has sailed, but we can probably merge this to M60.
,
Jun 21 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 21 2017
+Mano for TE verification.
,
Jun 22 2017
Tested the issue on Win-10 and Ubuntu 14.04 using latest canary #61.0.3138.0. Attached screen casts for reference Following are the steps followed to test the issue. ------------ 1. Launched chrome and navigated to URL: https://chrome.google.com/webstore/search/pdf%20viewer?utm_source=chrome-ntp-icon. 2. Clicked on 'ADD TO CHROME' button seen next to the first extension name. 3. Observed that the "Add extension" button enabled after a slight delay whereas default blue focus ring was present on the 'Cancel' button. ackermanb@ - Could you please verify the screen casts of both OS-Win and OS-Linux and please confirm the expected behavior. Thanks...!!
,
Jun 22 2017
Hey krajshree, yep the behavior is as expected. Thanks!
,
Jun 22 2017
,
Jun 22 2017
Thanks! Approving for merge into M60.
,
Jun 23 2017
As per comment #12, adding the verified labels. Thanks...!!
,
Jun 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c003ddd2dfa6f0605ba5a3f949e3558f7f15447 commit 2c003ddd2dfa6f0605ba5a3f949e3558f7f15447 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Jun 23 21:15:42 2017 Ensure default dialog button focus remains after a dialog update. BUG= 709346 Review-Url: https://codereview.chromium.org/2807653002 Cr-Original-Commit-Position: refs/heads/master@{#475165} Review-Url: https://codereview.chromium.org/2954203002 . Cr-Commit-Position: refs/branch-heads/3112@{#453} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/2c003ddd2dfa6f0605ba5a3f949e3558f7f15447/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc [modify] https://crrev.com/2c003ddd2dfa6f0605ba5a3f949e3558f7f15447/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc [modify] https://crrev.com/2c003ddd2dfa6f0605ba5a3f949e3558f7f15447/ui/views/window/dialog_client_view.cc [modify] https://crrev.com/2c003ddd2dfa6f0605ba5a3f949e3558f7f15447/ui/views/window/dialog_client_view_unittest.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Apr 7 2017Labels: hasbisect-per-revision
Owner: ackermanb@chromium.org
Status: Assigned (was: Unconfirmed)