New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709337 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Don't shrink the message center height while open

Project Member Reported by yoshiki@chromium.org, Apr 7 2017

Issue description

This is a chromium side issue of https://issuetracker.google.com/36517819.
 
Labels: M-58
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8057405c22f4ca9727ab53b845ee87ed1d865a73

commit 8057405c22f4ca9727ab53b845ee87ed1d865a73
Author: yoshiki <yoshiki@chromium.org>
Date: Tue Apr 18 09:20:28 2017

Don't shrink the message center height while open

Previously, the height of the message center shrank if necessary. But this patch changed this behavior and made it not shrank while the message center opens.

This patch also changes animation. Previously, the notifications above the target were animated. With this patch, the notifications below the target are animated. This is because now we don't update the height of message center so animating below is natural.

The reason why we don't use AnimateNotificationsBelowTarget() is that it has a bug on removing notification.

BUG= 709337 
BUG=b/36517819
TEST=manual
TEST=unittests pass

Review-Url: https://codereview.chromium.org/2805143002
Cr-Commit-Position: refs/heads/master@{#465184}

[modify] https://crrev.com/8057405c22f4ca9727ab53b845ee87ed1d865a73/ui/message_center/views/message_center_view.cc
[modify] https://crrev.com/8057405c22f4ca9727ab53b845ee87ed1d865a73/ui/message_center/views/message_center_view_unittest.cc
[modify] https://crrev.com/8057405c22f4ca9727ab53b845ee87ed1d865a73/ui/message_center/views/message_list_view.cc
[modify] https://crrev.com/8057405c22f4ca9727ab53b845ee87ed1d865a73/ui/message_center/views/message_list_view.h
[modify] https://crrev.com/8057405c22f4ca9727ab53b845ee87ed1d865a73/ui/message_center/views/message_list_view_unittest.cc

Labels: Merge-Request-58
Can I merge it to M58?
Labels: Merge-Request-59
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 18 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: We are only 6 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-58 Merge-Approved-58
Project Member

Comment 8 by sheriffbot@chromium.org, Apr 19 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 20 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/000f488c2c280953accc9f9e872f8e0912969dc6

commit 000f488c2c280953accc9f9e872f8e0912969dc6
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Thu Apr 20 08:37:47 2017

Don't shrink the message center height while open

Previously, the height of the message center shrank if necessary. But this patch changed this behavior and made it not shrank while the message center opens.

This patch also changes animation. Previously, the notifications above the target were animated. With this patch, the notifications below the target are animated. This is because now we don't update the height of message center so animating below is natural.

The reason why we don't use AnimateNotificationsBelowTarget() is that it has a bug on removing notification.

BUG= 709337 
BUG=b/36517819
TEST=manual
TEST=unittests pass

Review-Url: https://codereview.chromium.org/2805143002
Cr-Commit-Position: refs/heads/master@{#465184}
(cherry picked from commit 8057405c22f4ca9727ab53b845ee87ed1d865a73)

Review-Url: https://codereview.chromium.org/2827253002 .
Cr-Commit-Position: refs/branch-heads/3029@{#755}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/000f488c2c280953accc9f9e872f8e0912969dc6/ui/message_center/views/message_center_view.cc
[modify] https://crrev.com/000f488c2c280953accc9f9e872f8e0912969dc6/ui/message_center/views/message_center_view_unittest.cc
[modify] https://crrev.com/000f488c2c280953accc9f9e872f8e0912969dc6/ui/message_center/views/message_list_view.cc
[modify] https://crrev.com/000f488c2c280953accc9f9e872f8e0912969dc6/ui/message_center/views/message_list_view.h
[modify] https://crrev.com/000f488c2c280953accc9f9e872f8e0912969dc6/ui/message_center/views/message_list_view_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 20 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4595f544ddf229fe129c50b890b672073206e33b

commit 4595f544ddf229fe129c50b890b672073206e33b
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Thu Apr 20 08:41:46 2017

Don't shrink the message center height while open

Previously, the height of the message center shrank if necessary. But this patch changed this behavior and made it not shrank while the message center opens.

This patch also changes animation. Previously, the notifications above the target were animated. With this patch, the notifications below the target are animated. This is because now we don't update the height of message center so animating below is natural.

The reason why we don't use AnimateNotificationsBelowTarget() is that it has a bug on removing notification.

BUG= 709337 
BUG=b/36517819
TEST=manual
TEST=unittests pass

Review-Url: https://codereview.chromium.org/2805143002
Cr-Commit-Position: refs/heads/master@{#465184}
(cherry picked from commit 8057405c22f4ca9727ab53b845ee87ed1d865a73)

Review-Url: https://codereview.chromium.org/2831063002 .
Cr-Commit-Position: refs/branch-heads/3071@{#79}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/4595f544ddf229fe129c50b890b672073206e33b/ui/message_center/views/message_center_view.cc
[modify] https://crrev.com/4595f544ddf229fe129c50b890b672073206e33b/ui/message_center/views/message_center_view_unittest.cc
[modify] https://crrev.com/4595f544ddf229fe129c50b890b672073206e33b/ui/message_center/views/message_list_view.cc
[modify] https://crrev.com/4595f544ddf229fe129c50b890b672073206e33b/ui/message_center/views/message_list_view.h
[modify] https://crrev.com/4595f544ddf229fe129c50b890b672073206e33b/ui/message_center/views/message_list_view_unittest.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
9334.69.0, 58.0.3029.112 caroline

Sign in to add a comment